Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle is left open in importRootKeys #3039

Merged
merged 1 commit into from
Oct 12, 2021
Merged

handle is left open in importRootKeys #3039

merged 1 commit into from
Oct 12, 2021

Conversation

algonautshant
Copy link
Contributor

@algonautshant algonautshant commented Oct 12, 2021 •
edited by tsachiherman
Loading

Summary

The database handle is not closed in this code path.
In normal situations, this passes unnoticed, since it will be closed once the test terminates. However, when running the test multiple times, the OS will complain about too many open files.

Test Plan

This is a test infrastructure fix.

@algonautshant algonautshant self-assigned this Oct 12, 2021
tsachiherman
tsachiherman approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@tsachiherman tsachiherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Note that is a similar leak in messageRate_test.go:fetchSecretKey.

@tsachiherman tsachiherman merged commit da60399 into algorand:master Oct 12, 2021
@algonautshant algonautshant linked an issue Oct 12, 2021 that may be closed by this pull request
Too many open file: libgoalFixture #3048
Closed
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
@algonautshant @cce
handle is left open in importRootKeys (algorand#3039)
ba91b92 
## Summary

The database handle is not closed in this code path.
In normal situations, this passes unnoticed, since it will be closed once the test terminates. However, when running the test multiple times, the OS will complain about too many open files. 

## Test Plan
This is a test infrastructure fix.
@egieseke egieseke mentioned this pull request Nov 23, 2021
Merged
@algobarb algobarb mentioned this pull request Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianolson brianolson brianolson approved these changes

@tsachiherman tsachiherman tsachiherman approved these changes

Assignees

@algonautshant algonautshant

Labels
Team Carbon-11 unplanned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Too many open file: libgoalFixture
3 participants
@algonautshant @brianolson @tsachiherman