testing: fix TestLatestSigsFromThisNode #2940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timing issues between writing to and reading from the database cause the test to occasionally fail. Make the test more tolerant to such timing issues by polling.
Codecov Report
@@ Coverage Diff @@
## master #2940 +/- ##
==========================================
- Coverage 47.33% 47.28% -0.05%
==========================================
Files 355 355
Lines 57224 57224
==========================================
- Hits 27085 27060 -25
- Misses 27079 27102 +23
- Partials 3060 3062 +2
Continue to review full report at Codecov.
|
tsachiherman
suggested changes
Sep 23, 2021
| if len(latestSigs) == len(keys) { | ||
| break | ||
| } | ||
| time.Sleep(256 * time.Millisecond) |
There was a problem hiding this comment.
I would rather seeing this as an exponential backoff, but it's functionally correct as is.
tsachiherman
approved these changes
Sep 23, 2021
tsachiherman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Timing issues between writing to and reading from the database cause the test to occasionally fail.
Make the test more tolerant to such timing issues by polling.
Test Plan
This is a fix for a test.