Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: update EvalForIndexer to avoid totals computation #2941

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

tsachiherman
Copy link
Contributor

Summary

In the EvalForIndexer, we don't want to call finalValidation(). This would
skip the calculation of the account totals in the state delta, which is a serious
issue if it were to be used by algod, but it's perfectly fine for the indexer since
it doesn't track any totals and therefore cannot calculate the new totals.

Test Plan

Test against the indexer.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #2941 (48419a3) into master (e69b10d) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2941      +/-   ##
==========================================
- Coverage   47.33%   47.28%   -0.05%     
==========================================
  Files         355      355              
  Lines       57224    57220       -4     
==========================================
- Hits        27085    27055      -30     
- Misses      27079    27101      +22     
- Partials     3060     3064       +4     
Impacted Files Coverage Δ
ledger/evalIndexer.go 39.24% <ø> (+0.68%) ⬆️
network/wsPeer.go 72.14% <0.00%> (-3.07%) ⬇️
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) ⬇️
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) ⬇️
catchup/service.go 68.57% <0.00%> (-1.56%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
network/wsNetwork.go 60.90% <0.00%> (-0.19%) ⬇️
ledger/acctupdates.go 63.01% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69b10d...48419a3. Read the comment docs.

Copy link
Contributor

@tolikzinovyev tolikzinovyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tsachiherman tsachiherman merged commit e4fbb1d into algorand:master Sep 23, 2021
@tsachiherman tsachiherman deleted the tsachi/fixindexereval branch September 23, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants