e2e tests for log #2950
Merged
e2e tests for log #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/scripts/e2e_subs/e2e-logs.sh
Outdated
| curl -q -s -H "Authorization: Bearer $PUB_TOKEN" "$NET$1" | ||
| } | ||
|
|
||
| function app-txid { |
There was a problem hiding this comment.
Suggested change
| function app-txid { | |
| function app_txid { |
people usually tend not to use hyphens in var/func names
test/scripts/e2e_subs/e2e-logs.sh
Outdated
| # app create | ||
| TXID=$(${gcmd} app create --creator "${ACCOUNT}" --approval-prog=${TEAL}/logs.teal --global-byteslices 4 --global-ints 0 --local-byteslices 0 --local-ints 1 --clear-prog=${TEAL}/approve-all.teal | app-txid) | ||
| # log len | ||
| [ "$(rest "/v2/transactions/pending/$TXID" | jq '.logs | length')" = 32 ] |
There was a problem hiding this comment.
save result of rest "/v2/transactions/pending/$TXID" into a var and reuse it later in the loop and after.
Codecov Report
@@ Coverage Diff @@
## master #2950 +/- ##
==========================================
- Coverage 47.33% 47.30% -0.03%
==========================================
Files 355 355
Lines 57224 57224
==========================================
- Hits 27085 27069 -16
- Misses 27079 27093 +14
- Partials 3060 3062 +2
Continue to review full report at Codecov.
|
algorandskiy
previously approved these changes
Sep 24, 2021
algorandskiy
approved these changes
Sep 25, 2021
jannotti
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the log e2e tests to scripts/e2e_subs. This dir is used by the indexer to build blocks and queries.