Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: metrics_delta.py fixes #2962

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

brianolson
Copy link
Contributor

Summary

Fixes found during recent cluster bandwidth testing

Test Plan

This is test code for manual tests.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2021

Codecov Report

Merging #2962 (dd91b9d) into master (073717e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2962      +/-   ##
==========================================
- Coverage   47.57%   47.56%   -0.01%     
==========================================
  Files         358      358              
  Lines       57863    57863              
==========================================
- Hits        27527    27524       -3     
- Misses      27211    27216       +5     
+ Partials     3125     3123       -2     
Impacted Files Coverage Δ
catchup/service.go 68.57% <0.00%> (-1.56%) ⬇️
network/wsNetwork.go 60.90% <0.00%> (-0.19%) ⬇️
ledger/acctupdates.go 62.58% <0.00%> (+0.08%) ⬆️
ledger/blockqueue.go 82.18% <0.00%> (+1.14%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073717e...dd91b9d. Read the comment docs.

@tsachiherman
Copy link
Contributor

Please rerun failed tests

@algobolson
Copy link
Contributor

filed issue for flakey test. re-run started.

@tsachiherman tsachiherman changed the title metrics_delta.py fixes testing: metrics_delta.py fixes Sep 28, 2021
@tsachiherman tsachiherman merged commit 412aef5 into algorand:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants