fix flaky axfer txn e2e test #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/scripts/e2e_subs/app-assets.sh
Outdated
|
|
||
| ASSETID=$(asset-create 1000000 --name "e2e" --unitname "e" | asset-id) | ||
| [ "$(balance "$SMALL")" = 997000 ] # 1000 fee | ||
| [ "$(balance "$SMALL")" = 996000 ] # 1000 fee | ||
|
|
||
| ${gcmd} clerk send -a 1000000 -f "$ACCOUNT" -t "$APPACCT" |
There was a problem hiding this comment.
this one is still 1 Algo
Codecov Report
@@ Coverage Diff @@
## master #2973 +/- ##
==========================================
- Coverage 47.61% 47.60% -0.01%
==========================================
Files 358 358
Lines 57906 57906
==========================================
- Hits 27570 27566 -4
- Misses 27208 27213 +5
+ Partials 3128 3127 -1
Continue to review full report at Codecov.
|
algorandskiy
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The account balance check sometimes fails. This is because accounts with more than 1 algo are eligible to receive rewards and it varies when rewards would be added to an account.
This PR fixes this issue by funding accounts less than 1 algo.