Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: fix bug in TestRekeyUpgrade #3026

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

tsachiherman
Copy link
Contributor

@tsachiherman tsachiherman commented Oct 8, 2021

Summary

This test has a special handling is case the protocol upgrade completes before we can validate that without an upgrade the rekey feature won't work. However, when that does happen, AccountA is already rekeyed, and would require a different handling.

To avoid that while retaining the execution of the test, I've moved the second part to use a different set of accounts.

Test Plan

This is a test

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #3026 (bc9a9b8) into master (32e131c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3026   +/-   ##
=======================================
  Coverage   43.83%   43.83%           
=======================================
  Files         386      386           
  Lines       86767    86767           
=======================================
  Hits        38032    38032           
  Misses      42720    42720           
  Partials     6015     6015           
Impacted Files Coverage Δ
util/metrics/gauge.go 68.00% <0.00%> (-2.67%) ⬇️
util/metrics/counter.go 78.57% <0.00%> (-2.39%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
catchup/service.go 68.57% <0.00%> (-0.78%) ⬇️
ledger/acctupdates.go 67.21% <0.00%> (-0.10%) ⬇️
network/wsPeer.go 74.35% <0.00%> (+0.51%) ⬆️
data/transactions/verify/txn.go 44.29% <0.00%> (+0.87%) ⬆️
data/abi/abi_type.go 91.81% <0.00%> (+0.90%) ⬆️
ledger/catchpointwriter.go 69.48% <0.00%> (+1.29%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e131c...bc9a9b8. Read the comment docs.

Copy link
Contributor

@algonautshant algonautshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsachiherman tsachiherman merged commit 3c9e9e9 into algorand:master Oct 8, 2021
@tsachiherman tsachiherman deleted the tsachi/fixRekeyTest branch October 8, 2021 23:28
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
Summary
This test has a special handling is case the protocol upgrade completes before we can validate that without an upgrade the rekey feature won't work. However, when that does happen, AccountA is already rekeyed, and would require a different handling.

To avoid that while retaining the execution of the test, I've moved the second part to use a different set of accounts.

Test Plan
This is a test
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants