Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize circleci machine sizes and parallelism #3095

Merged
merged 9 commits into from
Oct 19, 2021

Conversation

algojack
Copy link
Contributor

@algojack algojack commented Oct 18, 2021

Since we increased a lot of things last week to pass beta tests quickly, we needed to go back and update machine sizes and parallelism for all but integration tests.

Tested on nightly tests, and few flaky tests failed on integration on first run, but on rerun passed: https://app.circleci.com/pipelines/github/algorand/go-algorand/2710/workflows/26b786ae-9d0b-403d-8e5a-29f8dd8919db

@algojack algojack changed the title Optimize circleci upload stage Optimize circleci machine sizes and parallelism Oct 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #3095 (01037ec) into master (78317e8) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3095      +/-   ##
==========================================
+ Coverage   43.66%   43.67%   +0.01%     
==========================================
  Files         391      391              
  Lines       86859    86859              
==========================================
+ Hits        37929    37938       +9     
+ Misses      42898    42893       -5     
+ Partials     6032     6028       -4     
Impacted Files Coverage Δ
data/abi/abi_type.go 90.90% <0.00%> (-0.91%) ⬇️
catchup/service.go 68.57% <0.00%> (-0.78%) ⬇️
ledger/internal/eval.go 69.94% <0.00%> (-0.27%) ⬇️
network/wsPeer.go 73.83% <0.00%> (-0.26%) ⬇️
network/wsNetwork.go 62.76% <0.00%> (+0.18%) ⬆️
ledger/acctupdates.go 64.95% <0.00%> (+0.69%) ⬆️
network/requestTracker.go 71.12% <0.00%> (+0.86%) ⬆️
data/transactions/verify/txn.go 44.29% <0.00%> (+0.87%) ⬆️
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) ⬆️
ledger/blockqueue.go 82.18% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78317e8...01037ec. Read the comment docs.

@algojack algojack requested a review from tsachiherman October 19, 2021 14:24
@algojack
Copy link
Contributor Author

please don't delete the branch when merging

@algojohnlee algojohnlee merged commit bd4cd9a into algorand:master Oct 19, 2021
@algojack algojack deleted the optimize-circleci-upload-stage branch October 19, 2021 18:05
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
Since we increased a lot of things last week to pass beta tests quickly, we needed to go back and update machine sizes and parallelism for all but integration tests.
algojohnlee pushed a commit that referenced this pull request Nov 15, 2021
Integration tests (specifically, e2e-go tests) seem to be having resource issues lately, so this returns integration tests to using large instances (4 cores, ~16GB RAM) after they were downsized to medium (2 cores ~8GB RAM) in #3095. Nightly integration tests are already using large VMs.
@egieseke egieseke mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants