Implemented New REST interfaces #3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/partkey #3099 +/- ##
===================================================
- Coverage 44.01% 43.95% -0.06%
===================================================
Files 394 394
Lines 87341 87463 +122
===================================================
+ Hits 38443 38445 +2
- Misses 42812 42930 +118
- Partials 6086 6088 +2
Continue to review full report at Codecov.
|
Resolves #2656 Implemented Handlers and e2e test for Participation ID REST: GET (Both specific and list of all installed) POST (Aka install) DELETE
winder
reviewed
Oct 19, 2021
| // TODO add this | ||
| "VoteID": crypto.OneTimeSignatureVerifier{}, | ||
| // TODO add this | ||
| "SelectionID": crypto.VRFVerifier{}, |
winder
reviewed
Oct 20, 2021
winder
reviewed
Oct 20, 2021
winder
reviewed
Oct 20, 2021
winder
reviewed
Oct 20, 2021
winder
reviewed
Oct 20, 2021
winder
reviewed
Oct 20, 2021
winder
reviewed
Oct 20, 2021
winder
reviewed
Oct 20, 2021
| @@ -0,0 +1,49 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
Other than a few nits, this test looks really nice. This is going to be a nice template for when the storage changes and we get new error cases to check for.
winder
reviewed
Oct 20, 2021
| @@ -894,6 +920,11 @@ func (node *AlgorandFullNode) InstallParticipationKey(partKeyBinary *[]byte) (ac | |||
| // Tell the AccountManager about the Participation (dupes don't matter) so we ignore the return value | |||
| _ = node.accountManager.AddParticipation(partkey) | |||
There was a problem hiding this comment.
On closer inspection, AddParticipation returns a bool not an error.:
// The return value indicates if the key has been added (true) or
// if this is a duplicate key (false).
The code would currently overwrite the duplicate key, I think that's probably fine. In the future when we stop writing the file to begin with, it would just be a no-op.
winder
reviewed
Oct 20, 2021
winder
reviewed
Oct 20, 2021
winder
reviewed
Oct 20, 2021
| # $5 - expected HTTP status code to check | ||
| # $6 - match result | ||
| # $7... - substring(s) that should be in the response | ||
| function verify { |
winder
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2656
Implemented Handlers and e2e test for Participation ID REST:
GET (Both specific and list of all installed)
POST (Aka install)
DELETE
Summary
Test Plan