Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling re-building of binaries in circleci during upload stage #3112

Merged
merged 35 commits into from
Oct 26, 2021
Merged

Disabling re-building of binaries in circleci during upload stage #3112

merged 35 commits into from
Oct 26, 2021

Conversation

algojack
Copy link
Contributor

No description provided.

algojack added 29 commits October 18, 2021 16:04
@algojack
Checking workspace attachment
ac7b00d
@algojack
Disabled more tests
aaf3445
@algojack
Tunning machine sizes
fb2db3f
@algojack
searching for bin folder
cafc639
@algojack
commented out more test filters
dfd115b
@algojack
searching for bin files
ff7b354
@algojack
Re-enabling nightly tests to check machine sizes and parallelism
97aeec1
@algojack
Cleaning up for machine size pr
6d144ff
@algojack
Merge branch 'master' into optimize-circleci-upload-stage
01037ec
@algojack
Revert "Cleaning up for machine size pr"
be57128 
This reverts commit 6d144ff.
@algojack
Added gopath
cca84b3
@algojack
skipping all tests
5255433
@algojack
creating build dir manually and skipping prep
e9b71a8
@algojack
removed debug statements
9fa3c38
@algojack
added prep go
01ae40f
@algojack
added go image
2325321
@algojack
Switched to python image and added a bunch of env vars
7d38291
@algojack
Switched to medium machine
79473b4
@algojack
Switched to medium machine part 2
c424850
@algojack
Enabling all archs
79e8bd7
@algojack
Filtering out unneeded flags
d30557b
@algojack
Reenabling tests
3cb62bf
@algojack
Revert "Reenabling tests"
b485b62 
This reverts commit 3cb62bf.
@algojack
Fixed typo
f8bf685
@algojack
Reenabling tests
4ad4964 
This reverts commit b485b62.
@algojack
restoring everything to before testing state
3a4c320
@algojack
Merge branch 'master' into optimize-circleci-upload-stage
f56c418
@algojack
Fixed branch setting
4ae79f1
@algojack
Moved executor
9458729
@algojack algojack requested a review from egieseke October 20, 2021 19:23
@algojack algojack self-assigned this Oct 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021 •
edited
Loading

Codecov Report

Merging #3112 (6a5753d) into master (c2054e5) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3112      +/-   ##
==========================================
- Coverage   43.68%   43.66%   -0.03%     
==========================================
  Files         390      390              
  Lines       86681    86681              
==========================================
- Hits        37868    37847      -21     
- Misses      42796    42816      +20     
- Partials     6017     6018       +1
Impacted Files Coverage Δ
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
network/wsPeer.go 69.86% <0.00%> (-2.94%) ⬇️
catchup/service.go 69.59% <0.00%> (-1.51%) ⬇️
ledger/internal/eval.go 69.94% <0.00%> (-0.27%) ⬇️
ledger/acctupdates.go 64.75% <0.00%> (-0.10%) ⬇️
network/wsNetwork.go 64.50% <0.00%> (ø)
ledger/blockqueue.go 85.05% <0.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2054e5...6a5753d. Read the comment docs.

egieseke
egieseke previously approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@egieseke egieseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

egieseke
egieseke approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@egieseke egieseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@algojohnlee algojohnlee merged commit e2d6349 into algorand:master Oct 26, 2021
@algojack algojack deleted the optimize-circleci-upload-stage branch October 27, 2021 16:11
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
@algojack @cce
Disabling re-building of binaries in circleci during upload stage (al…
12fdfb1 
…gorand#3112)
@egieseke egieseke mentioned this pull request Nov 23, 2021
Merged
@algobarb algobarb mentioned this pull request Dec 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egieseke egieseke egieseke approved these changes

@algobarb algobarb algobarb approved these changes

@bricerisingalgorand bricerisingalgorand Awaiting requested review from bricerisingalgorand

@onetechnical onetechnical Awaiting requested review from onetechnical

Assignees

@algojack algojack

Labels
Team Hyper Flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@algojack @codecov-commenter @egieseke @algobarb @algojohnlee