Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fields in ledger.Creatable public #3125

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

tolikzinovyev
Copy link
Contributor

Summary

Indexer needs to be able to set those fields.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #3125 (689f51f) into master (57a3306) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3125      +/-   ##
==========================================
- Coverage   43.71%   43.71%   -0.01%     
==========================================
  Files         390      390              
  Lines       86685    86685              
==========================================
- Hits        37894    37893       -1     
- Misses      42767    42768       +1     
  Partials     6024     6024              
Impacted Files Coverage Δ
ledger/evalindexer.go 51.61% <100.00%> (ø)
ledger/blockqueue.go 83.90% <0.00%> (-1.15%) ⬇️
catchup/service.go 70.35% <0.00%> (-0.76%) ⬇️
cmd/tealdbg/debugger.go 73.86% <0.00%> (+1.00%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57a3306...689f51f. Read the comment docs.

@tsachiherman tsachiherman merged commit 28e9eca into algorand:master Oct 21, 2021
cce pushed a commit to cce/go-algorand that referenced this pull request Oct 28, 2021
Summary
Indexer needs to be able to set those fields.
@egieseke egieseke mentioned this pull request Nov 23, 2021
@tolikzinovyev tolikzinovyev deleted the tolik/creatable-fields branch January 6, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants