-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make heapwatch.py port configurable #3143
Merged
algojohnlee
merged 3 commits into
algorand:master
from
bricerisingalgorand:brice/bandwidthTest
Oct 28, 2021
Merged
Make heapwatch.py port configurable #3143
algojohnlee
merged 3 commits into
algorand:master
from
bricerisingalgorand:brice/bandwidthTest
Oct 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algojack
reviewed
Oct 26, 2021
algojack
previously approved these changes
Oct 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #3143 +/- ##
=======================================
Coverage 43.78% 43.78%
=======================================
Files 391 391
Lines 86880 86880
=======================================
+ Hits 38038 38042 +4
+ Misses 42808 42806 -2
+ Partials 6034 6032 -2
Continue to review full report at Codecov.
|
onetechnical
approved these changes
Oct 26, 2021
algobarb
approved these changes
Oct 26, 2021
algojack
approved these changes
Oct 26, 2021
brianolson
approved these changes
Oct 27, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
This makes it possible to configure which port algod is running on when using heapWatch.py
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This makes it possible to configure which port algod is running on when using heapWatch.py
Test Plan
I tested this by running it against betanet and checking which port is getting used when the new arg is/isn't added.