Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse the network protocols ordering to de-prioritize the txnsync utilization #3153

Merged

Conversation

tsachiherman
Copy link
Contributor

Summary

In order to reduce risk on the migration to the new transaction sync, the network protocols order was flipped.
Nodes would default to use the old transaction propagation, and would use the new transaction propagation only when configured via the config.json "NetworkProtocol" flag.

Test Plan

Need to be tested on betanet.

@codecov-commenter
Copy link

Codecov Report

Merging #3153 (a685fd5) into master (ca3e877) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3153      +/-   ##
==========================================
+ Coverage   43.78%   43.80%   +0.01%     
==========================================
  Files         391      391              
  Lines       86880    86880              
==========================================
+ Hits        38041    38055      +14     
+ Misses      42806    42795      -11     
+ Partials     6033     6030       -3     
Impacted Files Coverage Δ
network/wsNetwork.go 65.19% <ø> (+0.49%) ⬆️
ledger/internal/eval.go 69.94% <0.00%> (-0.27%) ⬇️
ledger/acctupdates.go 64.65% <0.00%> (-0.20%) ⬇️
catchup/service.go 69.82% <0.00%> (+1.24%) ⬆️
network/wsPeer.go 72.80% <0.00%> (+1.59%) ⬆️
cmd/algoh/blockWatcher.go 80.95% <0.00%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3e877...a685fd5. Read the comment docs.

@tsachiherman tsachiherman merged commit 246ac13 into algorand:master Oct 28, 2021
@tsachiherman tsachiherman deleted the tsachi/reverseprotocolversions branch October 28, 2021 16:47
tsachiherman added a commit to tsachiherman/go-algorand that referenced this pull request Nov 2, 2021
ghost pushed a commit to nicholasguo/go-algorand that referenced this pull request Nov 20, 2021
tsachiherman pushed a commit that referenced this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants