Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report assembly error strings for compile API endpoint #3190

Merged
merged 4 commits into from
Nov 6, 2021

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Nov 5, 2021

Summary

This PR adds the assembly error strings so developers can see which errors were present in the program when calling the API. Prior to this change, the API only reported the number of errors in the program.

Closes #3082 .

Test Plan

Tested on sandbox.
Example program:

#pragma version 7
int v

Example response:

algosdk.error.AlgodHTTPError: 1: unsupported version: 7
2: strconv.ParseUint: parsing "v": invalid syntax

@algochoi algochoi requested a review from jannotti November 5, 2021 17:07
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

Merging #3190 (96066e6) into master (f72764b) will decrease coverage by 4.23%.
The diff coverage is 0.00%.

❗ Current head 96066e6 differs from pull request most recent head eac9636. Consider uploading reports for the commit eac9636 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3190      +/-   ##
==========================================
- Coverage   47.21%   42.98%   -4.24%     
==========================================
  Files         365      363       -2     
  Lines       58361    58353       -8     
==========================================
- Hits        27558    25082    -2476     
- Misses      27615    30188    +2573     
+ Partials     3188     3083     -105     
Impacted Files Coverage Δ
cmd/goal/clerk.go 9.18% <0.00%> (ø)
cmd/goal/multisig.go 10.00% <0.00%> (ø)
daemon/algod/api/server/v2/handlers.go 0.00% <0.00%> (ø)
data/transactions/logic/assembler.go 78.08% <0.00%> (-1.00%) ⬇️
ledger/internal/assetcow.go 0.00% <0.00%> (-100.00%) ⬇️
crypto/merklearray/worker.go 0.00% <0.00%> (-100.00%) ⬇️
crypto/compactcert/structs.go 0.00% <0.00%> (-100.00%) ⬇️
agreement/agreementtest/keyManager.go 0.00% <0.00%> (-100.00%) ⬇️
daemon/algod/api/server/lib/middlewares/auth.go 0.00% <0.00%> (-100.00%) ⬇️
agreement/agreementtest/simulate.go 0.00% <0.00%> (-87.68%) ⬇️
... and 103 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72764b...eac9636. Read the comment docs.

@jannotti jannotti merged commit 63e16ed into algorand:master Nov 6, 2021
@egieseke egieseke mentioned this pull request Nov 23, 2021
@algochoi algochoi deleted the algochoi/report-errors-api branch February 17, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly Error Message
3 participants