AVM: getbyte and setbyte description to say index must be within length of array #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannotti
requested changes
Mar 15, 2022
jannotti
reviewed
Mar 15, 2022
data/transactions/logic/README.md
Outdated
| | `setbit` | Copy of (byte-array or integer) A, with the Bth bit set to (0 or 1) C | | ||
| | `getbyte` | Bth byte of A, as an integer | | ||
| | `setbyte` | Copy of A with the Bth byte set to small integer (between 0..255) C | | ||
| | `getbit` | Bth bit of (byte-array or integer) A. If B is greater than or equal to the array length, the program fails | |
There was a problem hiding this comment.
need to change the clause to have an 8 * or something like that in it. If length is 2, 17 is the lowest failing bit index.
jannotti
approved these changes
Mar 15, 2022
This was referenced Apr 27, 2022
This was referenced May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brought up on discord, someone asked what the intended behaviour should be when providing an index greater than length of the array and noted it's not documented. Hopefully this helps.