AVM: Deadcode and basic block analysis #3870

jannotti · 2022-04-08T01:43:18Z

This PR improves assembly so that it detects typing errors if they occur within a basic block, even if there have been branches elsewhere in the code. It also allows "bad" code if the code is in a deadcode region, such as after an unconditional branch return, err, retsub...

It also continues to simplify the OpSpecs table by using helper functions to declare the opcode "Prototype" and other details, so there is less clutter.

Unify most assembly routines to minimize difference and ease doc gen Flexible opcode costs and fewer assembly routines

Ignores deadcode. Understands how jumps obscure typing info. Detects error within basic blocks Adds #pragma typetrack false Makes spec creation a bit more uniform

codecov-commenter · 2022-04-08T03:43:30Z

Codecov Report

Merging #3870 (caca024) into master (21b4bc5) will increase coverage by 0.18%.
The diff coverage is 88.64%.

@@            Coverage Diff             @@
##           master    #3870      +/-   ##
==========================================
+ Coverage   49.92%   50.10%   +0.18%     
==========================================
  Files         391      393       +2     
  Lines       68191    68301     +110     
==========================================
+ Hits        34044    34223     +179     
+ Misses      30431    30375      -56     
+ Partials     3716     3703      -13

Impacted Files	Coverage Δ
data/transactions/logic/fields.go	`77.10% <0.00%> (ø)`
data/transactions/logic/debugger.go	`56.70% <33.33%> (ø)`
data/transactions/logic/eval.go	`89.87% <86.84%> (+0.06%)`	⬆️
data/transactions/logic/assembler.go	`83.15% <89.39%> (+0.40%)`	⬆️
data/transactions/logic/opcodes.go	`84.76% <92.59%> (+3.03%)`	⬆️
data/transactions/logic/doc.go	`60.00% <100.00%> (+2.30%)`	⬆️
util/db/fullfsync_darwin.go	`100.00% <0.00%> (ø)`
libgoal/lockedFileUnix.go	`0.00% <0.00%> (ø)`
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b4bc5...caca024. Read the comment docs.

data/transactions/logic/TEAL_opcodes.md

data/transactions/logic/opcodes.go

data/transactions/logic/eval.go

data/transactions/logic/opcodes.go

data/transactions/logic/eval.go

data/transactions/logic/assembler.go

data/transactions/logic/eval.go

data/transactions/logic/assembler.go

data/transactions/logic/assembler_test.go

data/transactions/logic/assembler.go

data/transactions/logic/eval.go

…onsecutive Retain type tracking state during consecutive type tracking enablements

jasonpaulos

I like the proto change a lot

data/transactions/logic/opcodes.go

data/transactions/logic/assembler.go

data/transactions/logic/opcodes.go

Centralize OpStream initialization by introducing factory method

data/transactions/logic/assembler.go

Co-authored-by: Michael Diamant <[email protected]>

jannotti added 2 commits April 7, 2022 21:33

Simplify assembly and add flexible opcode cost support

ce1623b

Unify most assembly routines to minimize difference and ease doc gen Flexible opcode costs and fewer assembly routines

Mark exiting opcodes

3080b32

jannotti added the Enhancement label Apr 8, 2022

jannotti requested review from michaeldiamant, jasonpaulos and algorandskiy April 8, 2022 01:43

jannotti force-pushed the avm-deadcode branch from 07c76d3 to 3604926 Compare April 8, 2022 02:08

Tracks types more accurately during assembly

278b9ef

Ignores deadcode. Understands how jumps obscure typing info. Detects error within basic blocks Adds #pragma typetrack false Makes spec creation a bit more uniform

jannotti force-pushed the avm-deadcode branch from 3604926 to 278b9ef Compare April 8, 2022 02:57