-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics: specify telemetry hostname and instance name as prometheus labels #4089
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4089 +/- ##
==========================================
- Coverage 54.55% 54.49% -0.07%
==========================================
Files 391 391
Lines 48665 48669 +4
==========================================
- Hits 26549 26521 -28
- Misses 19890 19916 +26
- Partials 2226 2232 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if I can approve this. Hostname was specifically removed prior to launch to limit any personally identifiable information. I think we have a proxy data point which includes a hash of the host name and data directory path.
Maybe Prometheus is fine since it's more deliberate to opt into that?
The hostname feature you're describing must have been removed altogether — I only see getHostName which provides a GUID plus optional configurable "Name" which is what I'm interested in. |
Summary
This adds the telemetry hostname and instanceName to the labels passed to the MetricService, along with the other session label. They end up getting exported in Prometheus format as metric labels.
Test Plan
Existing tests should pass.