Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: specify telemetry hostname and instance name as prometheus labels #4089

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

cce
Copy link
Contributor

@cce cce commented Jun 7, 2022

Summary

This adds the telemetry hostname and instanceName to the labels passed to the MetricService, along with the other session label. They end up getting exported in Prometheus format as metric labels.

Test Plan

Existing tests should pass.

@cce cce changed the title specify telemetry hostname in prometheus metrics, if available metrics: specify telemetry hostname as prometheus labels Jun 7, 2022
@cce cce added the Enhancement label Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #4089 (e581ebb) into master (9237316) will decrease coverage by 0.06%.
The diff coverage is 35.00%.

@@            Coverage Diff             @@
##           master    #4089      +/-   ##
==========================================
- Coverage   54.55%   54.49%   -0.07%     
==========================================
  Files         391      391              
  Lines       48665    48669       +4     
==========================================
- Hits        26549    26521      -28     
- Misses      19890    19916      +26     
- Partials     2226     2232       +6     
Impacted Files Coverage Δ
daemon/algod/server.go 4.87% <0.00%> (-0.13%) ⬇️
logging/log.go 41.26% <0.00%> (ø)
logging/telemetryConfig.go 81.81% <0.00%> (ø)
logging/telemetryhook.go 50.35% <0.00%> (ø)
network/requestTracker.go 71.12% <0.00%> (ø)
network/wsNetwork.go 64.98% <56.00%> (ø)
ledger/roundlru.go 90.56% <0.00%> (-5.67%) ⬇️
ledger/blockqueue.go 82.18% <0.00%> (-2.88%) ⬇️
network/wsPeer.go 65.47% <0.00%> (-2.20%) ⬇️
ledger/tracker.go 74.45% <0.00%> (-2.17%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9237316...e581ebb. Read the comment docs.

@cce cce requested review from winder and brianolson June 8, 2022 03:11
Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I can approve this. Hostname was specifically removed prior to launch to limit any personally identifiable information. I think we have a proxy data point which includes a hash of the host name and data directory path.

Maybe Prometheus is fine since it's more deliberate to opt into that?

@cce
Copy link
Contributor Author

cce commented Jun 8, 2022

The hostname feature you're describing must have been removed altogether — I only see getHostName which provides a GUID plus optional configurable "Name" which is what I'm interested in.

@cce cce changed the title metrics: specify telemetry hostname as prometheus labels metrics: specify telemetry hostname and instance name as prometheus labels Jun 8, 2022
@cce cce merged commit d012599 into algorand:master Jun 9, 2022
@cce cce deleted the metrics-telemetry-host branch June 9, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants