AVM: Add support for Boxes #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: algochoi <[email protected]>
…and into readme-examples-for-goal
…llation and goal's executable path
…and into readme-examples-for-goal
At least three four left to consider, as well as extensive testing. Catchpoints, LRU cache, new hash costs
* README.md as committed to in the last retro * See https://gist.github.com/tzaffi/d57018cb826f4766f8f4ce2ba4dbaec8 for the Justfile that was originally in the PR.
Codecov Report
@@ Coverage Diff @@
## master #4149 +/- ##
==========================================
- Coverage 54.49% 54.18% -0.32%
==========================================
Files 407 413 +6
Lines 52425 53408 +983
==========================================
+ Hits 28569 28939 +370
- Misses 21472 22060 +588
- Partials 2384 2409 +25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Feature/avm box
algorandskiy
previously approved these changes
Oct 29, 2022
michaeldiamant
changed the title
|
PR looks ready to merge. Since I opened it, I can't approve. Note - Calling it out so it's not forgotten: #4704 is also needed for the release. |
jasonpaulos
previously approved these changes
Oct 31, 2022
cce
reviewed
Oct 31, 2022
| @@ -28,9 +28,8 @@ import ( | |||
| "github.com/algorand/go-algorand/protocol" | |||
| ) | |||
|
|
|||
| type logicLedger struct { | |||
| cow cowForLogicLedger | |||
There was a problem hiding this comment.
just noticed, the cowForLogicLedger interface is now no longer used as a type anywhere in the code — I guess the interface listing below mostly exists as documentation (??) but could be removed
There was a problem hiding this comment.
Removing. I thought I had - maybe it came back in a merge.
cce
reviewed
Oct 31, 2022
code review
jasonpaulos
approved these changes
Oct 31, 2022
This was referenced Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an integration branch PR to simplify tracking changes to
feature/avm-boxin support of #3890.