Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyPy + Jupyter Notebooks with Testing + Handle Txn Params #17

Merged
merged 84 commits into from
May 18, 2022
Merged
Show file tree
Hide file tree
Changes from 75 commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
fed6c64
separate out the algod liveness test
Apr 6, 2022
1d81276
separate out the algod liveness test
Apr 6, 2022
b5482d6
add lastMessage assertion and discover a problem with factorizer lsig
Apr 6, 2022
1697a10
flake8
Apr 6, 2022
45bd201
add hypothesis dependency - probly temporary
Apr 7, 2022
480d5c8
default message
Apr 7, 2022
65d5023
use upper case consts
Apr 7, 2022
fec8eda
rename fuzz-less for now
Apr 7, 2022
a76c347
versionize the factorizer games
Apr 7, 2022
b207aba
refactoring oh boy
Apr 8, 2022
269cbb1
passing tests
Apr 8, 2022
e9dbbda
lint
Apr 8, 2022
4020d72
pre-commit-check
Apr 8, 2022
72650be
add transactions into the CSV report
Apr 8, 2022
cfb9603
multi-proc the integration test
Apr 8, 2022
00a3b0c
graviton/py.typed
Apr 8, 2022
14016b0
mypy for graviton
Apr 8, 2022
ffd632a
make py 3.10 compatible
Apr 8, 2022
143f2b1
default txn_params in execute_one_dryrun()
Apr 9, 2022
3b4bcbc
mypy
Apr 10, 2022
1b2bbd4
Juypter notebook
Apr 12, 2022
6d55ace
wip
Apr 12, 2022
7228676
it still works
Apr 14, 2022
78bfa53
images
Apr 14, 2022
14d17ff
Update IMAGES.md
tzaffi Apr 14, 2022
8be5719
lint
Apr 14, 2022
248fa5a
missing comma
Apr 14, 2022
cf301fb
try pytest/nbmake to test Jupyter as well
Apr 14, 2022
e8998d9
distribute the notebook test and check that can pass with an intentio…
Apr 14, 2022
d80e98d
clarify comments
Apr 15, 2022
ef52891
declare much of the old code deprecated and break out into seperate m…
Apr 15, 2022
5416bb9
refactor deprecations
Apr 19, 2022
7465ae5
wrong import and dry_run --> dryrun
Apr 19, 2022
fc499fe
better docs and easier make commands
Apr 20, 2022
dc2c8be
proofreading
Apr 20, 2022
897bf72
space
Apr 20, 2022
9366e27
better explanation of passing with an erroring cell
Apr 20, 2022
155f213
trigger build
tzaffi Apr 21, 2022
4e9af8d
Trigger build 9:30 central
tzaffi Apr 21, 2022
6180e6e
Checkpoint enabling mypy
michaeldiamant May 13, 2022
a66eaed
Merge remote-tracking branch 'origin/main' into txn-params_mypy_jupyter
May 13, 2022
4f93019
silly timestamps
May 13, 2022
1548b3b
bump version + latest mypy
May 13, 2022
cc6a8b0
mypy
May 13, 2022
7d40211
comment
May 13, 2022
ac8caac
Update .github/workflows/build.yml
tzaffi May 13, 2022
592325c
Merge branch 'txn-params_mypy_jupyter' of github.com:algorand/gravito…
May 13, 2022
c6c4e5d
Enforce mypy
michaeldiamant May 14, 2022
a00027d
Use consistent ignore formatting
michaeldiamant May 14, 2022
a798ebb
Merge remote-tracking branch 'origin/mypy_enablement' into t-m-j
May 14, 2022
b022aed
temporary - TODO: remove commented out
May 14, 2022
8647207
finished merging in mypy_enablement branch
May 14, 2022
a612b97
version++
May 14, 2022
adc86ee
more default txn_params
May 14, 2022
a656291
smaller Makefile
May 14, 2022
f723acc
mypy
May 16, 2022
902d171
roundtrip teals
May 16, 2022
868779b
abi_strategy - pass unit tests
May 16, 2022
8585d42
ABI roundtrip tests pass!
May 17, 2022
da7c8d4
pass py 3.8
May 17, 2022
9cc914d
Update tests/integration/lsig_test.py
tzaffi May 17, 2022
9731815
Update tests/integration/lsig_test.py
tzaffi May 17, 2022
f568f52
Update tests/integration/lsig_test.py
tzaffi May 17, 2022
1728113
black
May 17, 2022
3017c8f
make tests skipping independent of local environment
May 17, 2022
35b5f27
rename comp -> mut
May 17, 2022
2034bbf
prep CHANGELOG
May 17, 2022
482258c
0.3.0
May 17, 2022
299c0f4
mypy for pyteal
May 17, 2022
e67aea4
don't use dict
May 17, 2022
849cded
improve Readme-Makefile consistency
May 17, 2022
c0c99dd
Update Makefile
tzaffi May 17, 2022
8b25326
typo
May 17, 2022
f21c957
last_rows --> last_steps
May 17, 2022
b901062
Update setup.py
tzaffi May 17, 2022
d6bc84a
Fix typos observed during PR review
michaeldiamant May 17, 2022
c778c8d
Merge pull request #18 from algorand/t-m-j_typos
tzaffi May 17, 2022
8e9b4fb
remove older `lsig_factorizer_game` versions and their tests
May 17, 2022
aa4d2b7
missed a fix
May 17, 2022
945aba2
add explanatory comment per commitment during code review
May 18, 2022
6ef4116
flake8
May 18, 2022
88e3dd7
Add provenance note for lsig_factorizer_game_1_5_7.teal
michaeldiamant May 18, 2022
86b140c
Add provenance note for lsig_factorizer_game_1_5_7.teal
michaeldiamant May 18, 2022
d8eaba5
Merge pull request #19 from algorand/t-m-j_test_note
tzaffi May 18, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,7 @@ jobs:
config: ${{ env.SANDBOX_CONFIG }}
- name: Setup integration test environment
run: make pip-development unit-test
- name: Run integration tests
- name: Setup Jupyter notebooks environment
run: make pip-notebooks
- name: Run integration tests and Jupyter notebooks
run: make gh-blackbox
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ sandbox
# Mac OS
.DS_Store

# asdf
.tool-versions

##### BEGIN: github recommends for Python #####

# Byte-compiled / optimized / DLL files
Expand Down
12 changes: 11 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
<!-- markdownlint-disable MD024 -->
# Changelog

## `v0.3.0` (_aka_ 🐈)

### Added

* `mypy`
* Jupyter Notebooks
* Allow handling of Transaction Params in Logic Sig and App Dry-Runs

## `v0.2.0` (_aka_ 🐗)

### Added
Expand Down Expand Up @@ -30,7 +38,9 @@
1. 🦙 (Alpaca) == `v0.1.0`
2. 🐗 (Boar) == `v0.2.0`
3. 🐈 (Cat) == `v0.3.0`

4. 🐕 (Dog) == `v0.4.0`
5. 🐘 (Elephant) == `v0.5.0`
6. 🐸 (Frog) == `v0.6.0`
... etc ...

## Tagging Cheatsheet
Expand Down
28 changes: 22 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,19 @@ pip:
pip-development: pip
pip install -e.[development]

flake8:
flake8 graviton tests
pip-notebooks: pip-development
pip install -e.[notebooks]

black:
black --check .

lint: black flake8
flake8:
flake8 graviton tests

mypy:
mypy .

lint: black flake8 mypy

unit-test:
pytest -sv tests/unit
Expand All @@ -26,10 +32,15 @@ blackbox-smoke-prefix:
ls -l sandbox
cd sandbox && docker-compose ps

NUM_PROCS = auto
VERBOSITY = -sv
integration-test:
pytest -sv tests/integration
pytest -n $(NUM_PROCS) --durations=10 $(VERBOSITY) tests/integration

all-tests: lint unit-test integration-test
notebooks-test:
pytest --nbmake -n $(NUM_PROCS) notebooks

all-tests: lint unit-test integration-test notebooks-test

###### Local Only ######

Expand All @@ -46,6 +57,11 @@ local-blackbox-smoke: blackbox-smoke-prefix local-sandbox-test

local-blackbox: local-blackbox-smoke integration-test

NOTEBOOK = notebooks/quadratic_factoring_game.ipynb
# assumes already ran `make pip-notebooks`
local-notebook:
jupyter retro $(NOTEBOOK)

# assumes act is installed, e.g. via `brew install act`:
local-gh-simulate:
act
Expand All @@ -58,4 +74,4 @@ gh-sandbox-test:

gh-blackbox-smoke: blackbox-smoke-prefix gh-sandbox-test

gh-blackbox: gh-blackbox-smoke integration-test
gh-blackbox: integration-test notebooks-test
Loading