Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluding gh-pages branch from cicd #325

Merged
merged 2 commits into from
May 25, 2022
Merged

Excluding gh-pages branch from cicd #325

merged 2 commits into from
May 25, 2022

Conversation

algojack
Copy link
Contributor

No description provided.

@algojack algojack self-assigned this May 24, 2022
onetechnical
onetechnical approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I also don't know how you test this. Maybe just wait for the next Java release?

algobarb
algobarb approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@algobarb algobarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we ultimately will need to add this config file to the gh-pages branch, right?

@algojack
Copy link
Contributor Author

merging for now, will open another PR to copy circleci config into gh-pages

@algojack algojack merged commit f7f8adb into develop May 25, 2022
@algojack algojack deleted the Excluding-gh-pages-branch-from-cicd branch May 25, 2022 20:22
@onetechnical onetechnical mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onetechnical onetechnical onetechnical approved these changes

@algobarb algobarb algobarb approved these changes

@algolucky algolucky algolucky approved these changes

@egieseke egieseke Awaiting requested review from egieseke

Assignees

@algojack algojack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@algojack @onetechnical @algobarb @algolucky