per pr review

algorand · Aug 25, 2022 · fb79379 · fb79379
1 parent 35ee2ad
commit fb79379
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/logic/logic.ts b/src/logic/logic.ts
@@ -164,8 +164,6 @@ function readPushByteOp(
  * check if passed in bytes are Algorand address or is B64 encoded, rather than Teal bytes
  *
  * @param program - Program bytes to check
- * @throws
- * @returns
  */
 export function sanityCheckProgram(program: Uint8Array) {
   if (!program || program.length === 0) throw new Error('empty program');
@@ -180,7 +178,7 @@ export function sanityCheckProgram(program: Uint8Array) {
   );
 
   if (isAsciiPrintable) {
-    const programStr = Buffer.from(program.buffer).toString();
+    const programStr = Buffer.from(program).toString();
 
     if (isValidAddress(programStr))
       throw new Error('requesting program bytes, get Algorand address');

diff --git a/tests/cucumber/steps/steps.js b/tests/cucumber/steps/steps.js
@@ -4475,9 +4475,8 @@ module.exports = function getSteps(options) {
   Then(
     'if the heuristic sanity check throws an error, the error contains {string}',
     async function (errMsg) {
-      if (errMsg !== '')
-        assert.strictEqual(this.actualErrMsg.includes(errMsg), true);
-      else assert.strictEqual(this.actualErrMsg === undefined, true);
+      if (errMsg !== '') assert.ok(this.actualErrMsg.includes(errMsg));
+      else assert.ok(this.actualErrMsg === undefined);
     }
   );