Minimize use of transactions to advance rounds in #360 #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algochoi
reviewed
Jul 28, 2022
| @@ -3,7 +3,7 @@ | |||
| from algosdk import account, constants, encoding, logic | |||
| from algosdk.future import transaction | |||
| from behave import given, then, when | |||
| from tests.steps.other_v2_steps import dev_mode_wait_for_confirmation | |||
| import tests.steps.other_v2_steps # Imports MaybeString | |||
algochoi
reviewed
Jul 28, 2022
algochoi
approved these changes
Jul 28, 2022
algochoi
reviewed
Jul 28, 2022
Co-authored-by: algochoi <[email protected]>
algochoi
added a commit
that referenced
this pull request
Aug 1, 2022
* Revise tests * Revise and delete v1 algod steps and add devmode helpers * Change testing branch * Formatting * Use randint instead of randbytes due to 3.8 support * Revert "Revise and delete v1 algod steps and add devmode helpers" This reverts commit d951d75. * Make v1 tests work again * Change testing branch * Delete debug print statements * Increase timeout and add back imports * Change circle configs to increase timeout * Delete v1 integration tests just to see passing CI * Revert v1 tests and add wait times * Change how txids are retrieved * Fix v1 steps again * Use v1 functions * Try fixing v1 tests * Skip v1 step when waiting for certain transactions to go through * Revert no output in CI * Disable v1 rekey test and some flaky v1 algod functions on dev mode * Delete redundant assert * Initialize dev mode accounts to prevent rekeying woes * Refactor some names and delete extra unused lines * Add some comments, refactor some variables, and change wait rounds to 1 in dev mode * Add env variable to use dev mode network * Rekey in separate account * Fix amounts to proportional amount and rename burn txns * Isolate dev account in v2 tests * Lower initial dev mode algo limit to avoid overspending * Minimize use of transactions to advance rounds in #360 (#365) * Wait for blocks using sleep instead of relying on status_after v1 api * Lets do some formatting * Bring back transaction check in v1 step * Revert setting network in run_integration script * Rename rekeying integ test * Revert branch back to master Co-authored-by: Michael Diamant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #360 to propose minimizing use of transactions to advance rounds.