fix comment in import#337 #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
DQinYuan
requested changes
Aug 14, 2024
src/test/java/com/ql/util/express/issue/Issue337CommentInImportTest.java
Outdated
Show resolved
Hide resolved
| ExpressRunner runner = new ExpressRunner(false, true); | ||
| DefaultContext<String, Object> context = new DefaultContext<>(); | ||
| Object result = runner.execute(express, context, null, false, true); | ||
| TestCase.assertEquals("successful", result); |
There was a problem hiding this comment.
junit4 一般习惯用 Assert.assertEquals
TestCase 在 junit3 中用的多一些, 本项目主要使用 junit4
src/test/java/com/ql/util/express/issue/Issue337CommentInImportTest.java
Show resolved
Hide resolved
|
有个单测在本地执行 |
是有问题，我看下 |
试了最新的v3.3.3 代码，也有这个问题，同时只有在maven test的时候才会复现，我新开个issue跟一下这个问题吧。 |
|
@jackie-coming 这个问题在 master 应该也存在很久了, 看起来像是测试框架引发的问题, 导致反射取不到字段 |
|
@jackie-coming 记得再开个 issue 跟这个问题,我先合并了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复首行注释解析问题