New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useWebSocket初始socketUrl为空报错，更新socketUrl导致无限重连 #2176

Closed

YinDongFang opened this issue Apr 26, 2023 · 1 comment · Fixed by #2177

Contributor

YinDongFang commented Apr 26, 2023

问题1：`useWebSocket`参数`socketUrl`初始值为空报错

复现地址：https://codesandbox.io/s/empty-initial-socketurl-z2uwvm?file=/App.tsx

预期：当初始socketUrl为空值时不执行connect

问题2：`useWebSocket`更新`socketUrl`导致无限重连

复现地址：https://codesandbox.io/s/update-socketurl-d1jjww?file=/App.tsx

复现步骤：等待连接成功后点击update

预期：更新socketUrl后重新建立连接并不会触发reconnect

The text was updated successfully, but these errors were encountered:

YinDongFang mentioned this issue

fix useWebSocket error (#2176) #2177

Merged

18 tasks

Contributor Author

YinDongFang commented Apr 27, 2023

相关issue：#1523

crazylxr closed this as completed in #2177

crazylxr pushed a commit that referenced this issue


          fix useWebSocket error (#2176) (#2177)

52bc820

* fix: useWebSocket don't call connect when socketUrl is empty (#2176)

* fix: useWebSocket unlimited reconnect when update socketUrl (#2176)

* fix: disconnect not works

* docs: modify useWebSocket docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment