Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Fix: Improve UX for search by allowing Search focus to be removed when clicking outside box #2666

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[ui] Fix: Improve UX for search by allowing Search focus to be removed when clicking outside box #2666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1ac6c3
[ui] Inspector 3D: Added mouse area to allow forcing focus to the par…
waaake Feb 6, 2025
1a08c31
[ui] ImageGallery: Added mouse area to allow forcing focus to the par…
waaake Feb 6, 2025
1931ce0
[ui] NodeEditor: Added mouse area to allow forcing focus to the paren…
waaake Feb 6, 2025
c1e28b0
[ui] Application: Added mouse area on menu bar area to allow forcing …
waaake Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions meshroom/ui/qml/Application.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,13 @@ Page {
}

Rectangle {
id: menuSpacer
MouseArea {
anchors.fill: parent
onClicked: {
menuSpacer.forceActiveFocus();
}
}
Layout.fillWidth: true
Layout.fillHeight: true
color: Qt.darker(activePalette.window, 1.15)
Expand Down Expand Up @@ -973,6 +980,12 @@ Page {
}

Rectangle {
MouseArea {
anchors.fill: parent
onClicked: {
menuSpacer.forceActiveFocus();
}
}
Layout.fillWidth: true
Layout.fillHeight: true
color: Qt.darker(activePalette.window, 1.15)
Expand Down Expand Up @@ -1007,6 +1020,7 @@ Page {
// Cache Folder
RowLayout {
spacing: 0
width: parent.width
MaterialToolButton {
font.pointSize: 8
text: MaterialIcons.folder_open
Expand All @@ -1021,6 +1035,17 @@ Page {
color: Qt.darker(palette.text, 1.2)
background: Item {}
}

Item {
Layout.fillWidth: true
Layout.fillHeight: true
MouseArea {
anchors.fill: parent
onClicked: {
footer.forceActiveFocus();
}
}
}
}
}

Expand Down
7 changes: 7 additions & 0 deletions meshroom/ui/qml/GraphEditor/NodeEditor.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,13 @@ Panel {
id: placeholder_component

Item {
id: panel
MouseArea {
anchors.fill: parent
onClicked: {
panel.forceActiveFocus();
}
}
Column {
anchors.centerIn: parent
MaterialLabel {
Expand Down
7 changes: 7 additions & 0 deletions meshroom/ui/qml/ImageGallery/ImageGallery.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -830,8 +830,15 @@ Panel {
}

Item {
id: spacer
Layout.fillHeight: true
Layout.fillWidth: true
MouseArea {
anchors.fill: parent
onClicked: {
spacer.forceActiveFocus();
}
}
}

MaterialToolLabelButton {
Expand Down
8 changes: 8 additions & 0 deletions meshroom/ui/qml/Viewer3D/Inspector3D.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,14 @@ FloatingPane {
}
}

MouseArea {
anchors.fill: parent
onClicked: {
/// Steal focus from anything that may have
mediaListView.forceActiveFocus();
}
}

model: SortFilterDelegateModel {
model: mediaLibrary.model
sortRole: ""
Expand Down