Add support for connecting GroupAttributes #2684
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centralize the handling of link assigment by value in a dedicated private method. Store link assignment by value in a separate member variable `_linkExpression`, to avoid manipulating a internal `_value` that can represent different concepts (value VS serialized edge expression).
Make GroupAttributes connectable by supporting: - link assignment - applying link expression - considering linkParam within appropriate methods
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #2684 +/- ##
===========================================
+ Coverage 72.79% 72.82% +0.02%
===========================================
Files 129 129
Lines 7753 7779 +26
===========================================
+ Hits 5644 5665 +21
- Misses 2109 2114 +5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for connecting GroupAttributes.
Features list
Implementation remarks