Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/contract desc #53

Merged
merged 16 commits into from
Jan 2, 2023
Merged

Feat/contract desc #53

merged 16 commits into from
Jan 2, 2023

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Dec 28, 2022 •
edited
Loading

Describe your changes in contract detail page

Implement contract description.

  • Link in description is clickable
  • Expand and collapse if text occupy more than 2 or 4 line
  • Able to see user contract description
  • Able to see public contract descriptions if exist

Button and display

  • Show "edit button" if contract has contract description (render contract description)
  • Show "Add description" if contract is saved but does not have contract description (render no contract description)

@vercel
Copy link

vercel bot commented Dec 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
celatone-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 2, 2023 at 1:02PM (UTC)
celatone-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 2, 2023 at 1:02PM (UTC)

evilpeach
evilpeach requested changes Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We don't use npm. so, remove package-lock.json
  2. Fix CHANGELOG.md conflict

@bkioshn bkioshn requested a review from evilpeach December 30, 2022 15:46
evilpeach
evilpeach requested changes Dec 31, 2022
View reviewed changes
@bkioshn bkioshn requested a review from evilpeach December 31, 2022 13:49
@bkioshn bkioshn requested a review from evilpeach January 2, 2023 06:19
@bkioshn bkioshn merged commit dfaa8db into develop Jan 2, 2023
@bkioshn bkioshn deleted the feat/contract-desc branch January 2, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evilpeach evilpeach evilpeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkioshn @evilpeach