Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boolean values support for display-if #243

Conversation

jitendraharpalani58
Copy link
Contributor

@danielbachhuber
Copy link
Contributor

@mboynes #reviewmerge?

@mboynes
Copy link
Contributor

mboynes commented Oct 29, 2014

This looks good to me but haven't tested it yet. @danielbachhuber if you have, go ahead and merge it

@danielbachhuber
Copy link
Contributor

@jitendraharpalani58 After switching to 636 in our repo, when I toggle the <select>, I only get "1" as a string:

image

My console.log() is here:

image

Do you get different?

@danielbachhuber
Copy link
Contributor

@jitendraharpalani58 what's going on here?

@jitendraharpalani58
Copy link
Contributor Author

@danielbachhuber let me take a look. I thought it was good to go... will update in a bit.

@jitendraharpalani58
Copy link
Contributor Author

@danielbachhuber console value that you pointed is the "display-if" value we have set. That means display the field if its true ( 1 ). Thus its always "1".

If you want to see the toggle. Console value at line 180 which is the value of the select field.

screen shot 2014-12-17 at 1 08 27 am

I checkout this branch, works just fine for 1 & 0, as well as, true and false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants