Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in travis config, update WP #511

Merged
merged 1 commit into from
Jul 25, 2016
Merged

Fix bug in travis config, update WP #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ language: php
matrix:
include:
- php: 5.3
env: WP_VERSION=4.3.3
env: WP_VERSION=4.4.4
- php: 5.3
env: WP_VERSION=latest
- php: 5.6
Expand Down Expand Up @@ -39,7 +39,13 @@ script:
- |
if [[ ! -z "$WP_VERSION" ]] ; then
phpunit
fi
- |
if [[ ! -z "$WP_VERSION" ]] ; then
Copy link
Contributor

@kjbenk kjbenk Jul 25, 2016 •
edited by mboynes
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there is specific reason why the phpunit needs WP_VERSION, when it is not needed in other travis configs we use internally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The travis config that we use internally is a little different. This is really aimed at future improvements to FM's travis config.

phpunit -c multisite.xml
fi
- |
if [[ ! -z "$WP_VERSION" ]] ; then
grunt qunit:specific --wp=$WP_VERSION
fi
- |
Expand Down