PHPCS for TextArea and Datepicker #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: - Generic.Commenting.DocComment.MissingShort - Generic.Commenting.DocComment.SpacingBeforeTags - Generic.Files.EndFileNewline.NotFound - Squiz.Commenting.FileComment.Missing - Squiz.Commenting.FunctionComment.MissingParamComment - Squiz.Commenting.FunctionComment.SpacingAfterParamType
Fixes: - Generic.Commenting.DocComment.MissingShort - Generic.Commenting.DocComment.SpacingBeforeTags - Generic.ControlStructures.InlineControlStructure.NotAllowed - Generic.PHP.LowerCaseConstant.Found - Squiz.Commenting.FileComment.Missing - Squiz.Commenting.FunctionComment.MissingParamComment - Squiz.Commenting.FunctionComment.MissingParamName - Squiz.Commenting.FunctionComment.MissingParamTag - Squiz.Commenting.FunctionComment.ParamCommentFullStop - Squiz.Commenting.FunctionComment.ParamNameNoMatch - Squiz.Commenting.InlineComment.InvalidEndChar - WordPress.PHP.YodaConditions.NotYoda - WordPress.WhiteSpace.OperatorSpacing.NoSpaceAfter
| */ | ||
| public function presave( $value, $current_value = array() ) { | ||
| $time_to_parse = sanitize_text_field( $value['date'] ); | ||
| if ( isset( $value['hour'] ) && is_numeric( $value['hour'] ) && $this->use_time ) { | ||
| $hour = intval( $value['hour'] ); | ||
| $minute = ( isset( $value['minute'] ) && is_numeric( $value['minute'] ) ) ? intval( $value['minute'] ) : 0; | ||
| if ( $hour == 0 && $this->use_am_pm ) $hour = 12; | ||
| if ( 0 == $hour && $this->use_am_pm ) { |
There was a problem hiding this comment.
Should this use the strict comparison?
There was a problem hiding this comment.
Possibly, but I don't want to risk changing the field's behavior in this PR, which is intended only to make the field standards-compliant.
There was a problem hiding this comment.
Ok, but I thought using a strict comparison was making it standards compliant :) Though it is only a warning so I guess it is fine.
There was a problem hiding this comment.
I don't see a problem with making that change now
|
Very minor comment, otherwise ⛳ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #271.