Support display_if for page templates
#681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinfodness
approved these changes
Dec 18, 2017
|
|
||
| public function test_display_if_markup_for_page_template() { | ||
| $name = rand_str(); | ||
| $template = 'toaster.php'; |
There was a problem hiding this comment.
I'm sure there's a good story behind this.
There was a problem hiding this comment.
😄
I wish it was more than this being a word unlikely to come up in a non-testing context. Instead of foo and bar, I use waffle iron and toaster pastry, for reasons I can no longer recall; probably something about being self-taught and learning programming when I was a hungry teenager. 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page templates are a special field in Core, and rather than requiring hidden fields to support conditioning a field on them, FM should handle them accordingly.
By specifying the
page_templatekey instead of thesrcandvaluekeys, this will toggle fields based on the chosen page template.Fixes #414