-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the calling class to the string for the ajax hash to prevent collisions #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌳 I wondered whether the post, term, and user datasources should get the same fix, since they override the default get_ajax_action()
. But I see that each has a distinct leading string like fm_datasource_post
and fm_datasource_term
...except for the user datasource, which also uses fm_datasource_post
(oops!). Can we switch that to fm_datasource_user
while we're here? (Or drop the _type_
prefix from each and use get_called_class()
like in the parent class.)
😆 |
@dlh01 I updated the other classes to all use |
@mslinnea Unfortunately, it seems that using I'm wondering whether the class name should be part of the hashed string instead, so maybe |
@dlh01 Valid point, I've updated these so that the called class is part of the hash, and I also fixed the preface for the user datasource. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌳 Now we're cookin' with get_called_class()
!
Addresses #621