Improvements and bug fixes for the compose buffer enhancements #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the "dispatch" commands consistently. - Re-order to have the two "Write message" bindings adjacent. - Fix bug wrt the S-<return> binding in the transient menu (see also alphapapa#269).
|
I've cleaned up the earlier WIP commits (just removing the debugging messages and writing proper commit messages), and otherwise this code is what I've been using for the past several days. I've decided not to worry about the remaining auto-height edge case that I'd seen while testing -- it is harmless, and I believe it is unlikely to affect people in practice in any case, and I didn't wish to complicate the code further on that account. |
added 2 commits
March 18, 2024 22:50
A variety of changes to address edge-cases which might cause compose buffer windows to be the wrong height. (ement-room-compose-buffer-window-auto-height-fixed) New variable. (ement-room-compose-buffer-window-state-change-handler) (ement-room-compose-buffer-window-buffer-change-handler) New handler functions used in buffer-local window change hooks. (ement-room-init-compose-buffer) Apply the fixes. (ement-room-compose-buffer-window-auto-height) Prevent recursion.
A dedicated window will not be used to display any other buffer, and will be deleted by `quit-restore-window' (both of which are desirable, as our default auto-height behaviour generally keeps compose buffer windows too small to usefully display other buffers.) Fix: Use consistent window handling when exiting compose buffers. (ement-room-compose-buffer-window-dedicated) New option. (ement-room-compose-buffer-window-buffer-change-handler) Make window dedicated when appropriate. (ement-room-compose-buffer-quit-restore-window) New function. (ement-room-compose-send-direct, ement-room-compose-abort) Use it.
|
Force-pushed to squash this addition into the "More robust auto-height behaviour" commit: ;; Ask Emacs to "preserve" the new height. So long as the window
;; maintains this height and is displaying this specific buffer, Emacs
;; will avoid unnecessary height changes from side-effects of commands
;; such as `balance-windows'. Explicit height changes are allowed.
;; We must update this parameter every time we change the height so
;; that the "preserved" height value is always correct.
(window-preserve-size nil nil t) |
|
Thanks, Phil! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A handful of bug fixes and enhancements following on from #236.