Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix inheritance in face definitions #303

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

tarsius
Copy link
Contributor

@tarsius tarsius commented Oct 2, 2024

The byte-compiler of Emacs 31 has started to warn about these.

@alphapapa alphapapa self-assigned this Oct 2, 2024
@alphapapa alphapapa added the bug Something isn't working label Oct 2, 2024
@alphapapa alphapapa added this to the v0.16 milestone Oct 2, 2024
@alphapapa
Copy link
Owner

Ah, how sloppy of me. Thank you, Jonas.

@phil-s
Copy link

phil-s commented Oct 3, 2024

I think this one was a mistake?

-  '((t (:inherit italic ement-room-list-name)))
+  '((t (:inherit italic :inherit ement-room-list-name)))

Testing that, the :inherit italic simply gets clobbered by the :inherit ement-room-list-name.

The byte-compiler of Emacs 31 has started to warn about these.
@tarsius
Copy link
Contributor Author

tarsius commented Oct 3, 2024

I think this one was a mistake?

Indeed. Fixed.

@alphapapa alphapapa merged commit 30d4196 into alphapapa:master Oct 12, 2024
0 of 4 checks passed
@alphapapa
Copy link
Owner

Thanks, Jonas.

@tarsius tarsius deleted the inherit branch October 12, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants