Do not signal error on successful non-200 HTTP status codes

[josephmturner]

Currently, plz.el signals plz-http-error on anything besides a status 200 code. According to Mozilla, only status codes between 400-599 are errors.

I was confused when I received a successful 201 status code and plz.el signaled an HTTP error.

[alphapapa]

Hi Joseph,

Yes, this is an artifact of plz being relatively new and not having needed to interact with other 2xx codes before. Issue #7 is also related to this.

The question now is how to handle other 2xx codes. I guess we could simply treat them the same as 200, and clients that need to handle specific 2xx codes differently could use :as 'response and check the code in the :then function.

What do you think? Thanks.

[Dima-369]

The question now is how to handle other 2xx codes. I guess we could simply treat them the same as 200, and clients that need to handle specific 2xx codes differently could use :as 'response and check the code in the :then function.

That sounds great! I vote for this :)

Once this is implemented, it would be great if this is noted in the README with an example of how to check for the status code!

[josephmturner]

The question now is how to handle other 2xx codes. I guess we could simply treat them the same as 200, and clients that need to handle specific 2xx codes differently could use :as 'response and check the code in the :then function.

I like this simple solution. If at some point it seems appropriate for plz.el to handle specific 2xx codes, that can be implemented later.

[josephmturner]

Thank you!

[alphapapa]

Going to reopen this to remind me to update the docs as mentioned.

[alphapapa]

Done.