feat: add back-to-top button #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simonwei97 <[email protected]>
george-gca
requested changes
May 17, 2024
Signed-off-by: simonwei97 <[email protected]>
Light Theme
Dark Theme
|
george-gca
approved these changes
May 20, 2024
Signed-off-by: Simonwei97 <[email protected]>
|
I sync latest code and update code formatter. Need run workflow again. |
Signed-off-by: Simonwei97 <[email protected]>
MarcinWiech
pushed a commit
to MarcinWiech/marcinwiech.github.io
that referenced
this pull request
May 22, 2024
slove alshedivat#2425 Demo: <img width="1643" alt="image" src="https://github.com/alshedivat/al-folio/assets/119845914/ea73b84b-1d09-4af8-b1ba-6090595f5ab7"> --------- Signed-off-by: simonwei97 <[email protected]> Signed-off-by: Simonwei97 <[email protected]>
george-gca
pushed a commit
that referenced
this pull request
May 24, 2024
Fixes #2425 PR #2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
george-gca
added a commit
to george-gca/multi-language-al-folio
that referenced
this pull request
May 24, 2024
* Updated tikzjax hash * Added support for search (alshedivat#2415) Added support for search within the template as suggested in alshedivat#581. I decided to go with a client side search based on [Ninja keys](https://github.com/ssleptsov/ninja-keys), but using [deepdub's fork](https://github.com/deepdub-ai/ninja-keys) as basis since it supports fuzzy search. Had to do a bunch of changes to their code to make it work without using node to install everything. Also changed to use some colors defined in our side and using both pages' titles and descriptions for search. Also had to increase the template max width to better accomodate the new item in navigation bar. Missing implementations: - [ ] One thing I'd love to do (but currently have no idea how) would be to change the text next to the search button depending on the platform. For example, if the user is accessing the site on a mac they should use ⌘k instead of ctrl k. - [x] Test how this looks like (and how it is supposed to work) on devices with smaller screens - [x] Support for offline mode Some screenshots: --- ## Dark version    --- ## Light version    --------- Signed-off-by: George Araujo <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: Add back-to-top button (alshedivat#2433) Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md` * Moved search data inside search.liquid (alshedivat#2439) Signed-off-by: George Araujo <[email protected]> * Fixed merg bug Signed-off-by: George Araujo <[email protected]> * Translated search strings Signed-off-by: George Araujo <[email protected]> * Fixed spacing in liquid variables Signed-off-by: George Araujo <[email protected]> * Fixed all weird spacing between liquid variables and curly braces Signed-off-by: George Araujo <[email protected]> * Increased site max width Signed-off-by: George Araujo <[email protected]> * Fixed urls not being localized in search Signed-off-by: George Araujo <[email protected]> * Fixed prettier complaints Signed-off-by: George Araujo <[email protected]> --------- Signed-off-by: George Araujo <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Abhilesh Dhawanjewar <[email protected]>
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this pull request
Jun 19, 2024
slove alshedivat#2425 Demo: <img width="1643" alt="image" src="https://github.com/alshedivat/al-folio/assets/119845914/ea73b84b-1d09-4af8-b1ba-6090595f5ab7"> --------- Signed-off-by: simonwei97 <[email protected]> Signed-off-by: Simonwei97 <[email protected]>
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this pull request
Jun 19, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
karapostK
pushed a commit
to karapostK/karapostK.github.io
that referenced
this pull request
Jul 4, 2024
slove alshedivat#2425 Demo: <img width="1643" alt="image" src="https://github.com/alshedivat/al-folio/assets/119845914/ea73b84b-1d09-4af8-b1ba-6090595f5ab7"> --------- Signed-off-by: simonwei97 <[email protected]> Signed-off-by: Simonwei97 <[email protected]>
karapostK
pushed a commit
to karapostK/karapostK.github.io
that referenced
this pull request
Jul 4, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
Suraj-Bhor
pushed a commit
to Suraj-Bhor/suraj-bhor.github.io
that referenced
this pull request
Aug 13, 2024
slove alshedivat#2425 Demo: <img width="1643" alt="image" src="https://github.com/alshedivat/al-folio/assets/119845914/ea73b84b-1d09-4af8-b1ba-6090595f5ab7"> --------- Signed-off-by: simonwei97 <[email protected]> Signed-off-by: Simonwei97 <[email protected]>
Suraj-Bhor
pushed a commit
to Suraj-Bhor/suraj-bhor.github.io
that referenced
this pull request
Aug 13, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
YifanJiang233
pushed a commit
to YifanJiang233/al-folio
that referenced
this pull request
Aug 27, 2024
slove alshedivat#2425 Demo: <img width="1643" alt="image" src="https://github.com/alshedivat/al-folio/assets/119845914/ea73b84b-1d09-4af8-b1ba-6090595f5ab7"> --------- Signed-off-by: simonwei97 <[email protected]> Signed-off-by: Simonwei97 <[email protected]>
YifanJiang233
pushed a commit
to YifanJiang233/al-folio
that referenced
this pull request
Aug 27, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
meiqing-wang
pushed a commit
to meiqing-wang/meiqing-wang.github.io
that referenced
this pull request
Oct 13, 2024
slove alshedivat#2425 Demo: <img width="1643" alt="image" src="https://github.com/alshedivat/al-folio/assets/119845914/ea73b84b-1d09-4af8-b1ba-6090595f5ab7"> --------- Signed-off-by: simonwei97 <[email protected]> Signed-off-by: Simonwei97 <[email protected]>
meiqing-wang
pushed a commit
to meiqing-wang/meiqing-wang.github.io
that referenced
this pull request
Oct 13, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
avishekanand
pushed a commit
to avishekanand/al-folio-homepage
that referenced
this pull request
Oct 22, 2024
slove alshedivat#2425 Demo: <img width="1643" alt="image" src="https://github.com/alshedivat/al-folio/assets/119845914/ea73b84b-1d09-4af8-b1ba-6090595f5ab7"> --------- Signed-off-by: simonwei97 <[email protected]> Signed-off-by: Simonwei97 <[email protected]>
avishekanand
pushed a commit
to avishekanand/al-folio-homepage
that referenced
this pull request
Oct 22, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
mattleblanc
pushed a commit
to mattleblanc/mattleblanc.github.io
that referenced
this pull request
Dec 29, 2024
slove alshedivat#2425 Demo: <img width="1643" alt="image" src="https://github.com/alshedivat/al-folio/assets/119845914/ea73b84b-1d09-4af8-b1ba-6090595f5ab7"> --------- Signed-off-by: simonwei97 <[email protected]> Signed-off-by: Simonwei97 <[email protected]>
mattleblanc
pushed a commit
to mattleblanc/mattleblanc.github.io
that referenced
this pull request
Dec 29, 2024
Fixes alshedivat#2425 PR alshedivat#2427 adds a back-to-top button, however the button overlaps with the footer when `footer_fixed: false` and [has inadequate spacing](alshedivat#2425 (comment)) with `footer_fixed: true` Changes in this PR: - Fix positioning of button on fixed and sticky footer layouts - Add option to disable back-to-top button by setting `back_to_top: false` in `_config.yml` - Add button transparency to avoid button blocking content view - Reduce size of button Demo - | Device | Fixed footer | Sticky footer | | :-----------: | :-------------: | :-----------: | | Mobile |  |  | | Desktop |  |  | Miscellaneous change - Added personal website under `Academics` to `README.md`
MarcinWiech
pushed a commit
to MarcinWiech/marcinwiech.github.io
that referenced
this pull request
Feb 28, 2025
slove alshedivat#2425 Demo: <img width="1643" alt="image" src="https://github.com/alshedivat/al-folio/assets/119845914/ea73b84b-1d09-4af8-b1ba-6090595f5ab7"> --------- Signed-off-by: simonwei97 <[email protected]> Signed-off-by: Simonwei97 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slove #2425
Demo: