Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back UI tabs for settings #2076

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

Meister1593
Copy link
Collaborator

I'm unsure if it looks like a hack (the way it works) or a good solution, but i thought it's the best way considering it's coming from schema

@Meister1593 Meister1593 requested review from zmerp and Vixea April 17, 2024 18:53
@Meister1593 Meister1593 self-assigned this Apr 17, 2024
@Meister1593 Meister1593 marked this pull request as draft April 17, 2024 18:53
@Meister1593
Copy link
Collaborator Author

image
image
image

@Meister1593
Copy link
Collaborator Author

Final look
image
image
image

@Meister1593 Meister1593 marked this pull request as ready for review April 17, 2024 19:26
Copy link
Collaborator

@Vixea Vixea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's not much I can do without a PC and zarik approves I'll just approve it too

@Vixea
Copy link
Collaborator

Vixea commented Apr 26, 2024

Tested and merging

@Vixea Vixea merged commit bd23d3c into alvr-org:master Apr 26, 2024
6 checks passed
@zmerp zmerp mentioned this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants