Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): 🐛 Use device_id field for hostname instead of mDNS hostname #2077

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

zmerp
Copy link
Member

@zmerp zmerp commented Apr 17, 2024

Also, improve error message for mismatched version.

@zmerp zmerp requested a review from shinyquagsire23 April 17, 2024 19:25
@Meister1593
Copy link
Collaborator

Assuming Android will hopefully eventually use mDNS and have same better messages?

Copy link
Contributor

@shinyquagsire23 shinyquagsire23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vixea Vixea merged commit 73af025 into master Apr 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants