Fix panic message boxes #2086
Merged
Fix panic message boxes #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you do a before and after |
|
Before: |
Vixea
approved these changes
Apr 23, 2024
Vixea
reviewed
Apr 23, 2024
|
|
||
| #[cfg(all(not(target_os = "android"), feature = "enable-messagebox"))] | ||
| std::thread::spawn(move || { | ||
| rfd::MessageDialog::new() | ||
| .set_title("ALVR panicked") | ||
| .set_description(&err_str) | ||
| .set_description(&short_err_str) |
There was a problem hiding this comment.
Maybe use panic_info directly here?
|
I believe the issue is that rfd does not support new lines in the string. Not actually about the panic info in particular. Try calling alvr_common::show_e() with a new line in it. |
|
@SniperJoe ping. Please do more tests as I suggested, as the code of this PR doesn't really explain why it fixes the issue. |
|
@zarik5 tested with the long error with removed line breaks. Still not showing correctly. |
|
@zarik5 also tried to show a short error with one \n, all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when alvr-server panics, it displays a message box with the panic info. But the rfd::MessageDialog replaces the whole message box content with just "An error occuried" which is not really informative. I played around it a little bit and it seems that it does not accept the panic info as the message box content.
Solution: Shorten the info to display. After that the message box is displayed normally.