fix(launcher): 🐛 Fix installation popup

[zmerp]

No description provided.

[The-personified-devil]

How does this work?

[KyleCarr]

This change makes it so instead of creating a copy of the release channel version, it is actually mutable. This should save memory overall I believe right?

[zmerp]

Basically i refactored away some logic for the popup, and in doing so we now need to call some code in a closure. Closures often means aliasing issues so I usually clone the variables needed. This time though we needed to mutate the variable (version) so the result was that the dropdowns didn't select anything anymore.

[The-personified-devil]

This change makes it so instead of creating a copy of the release channel version, it is actually mutable. This should save memory overall I believe right?

Yea that's what the diff says, but the question is why it's done. It's clearly a fix going by the diff message, so this somehow has to fix something

[zmerp]

@KyleCarr this is not about memory saving. It was actually a bug caused by a refactoring. Most of the code in ALVR doesn't care about memory usage, apart some crucial paths while dealing with video buffers

[The-personified-devil]

This time though we needed to mutate the variable (version) so the result was that the dropdowns didn't select anything anymore.

Could've found that out myself tbh, I just keep getting blinded a bit by the lack of context from diff views

[zmerp]

Yeah I would have never found this myself even staring at the code for hours. It was reported in the Discord server. It slipped my testing apparently.

[The-personified-devil]

Yeah I would have never found this myself even staring at the code for hours. It was reported in the Discord server. It slipped my testing apparently.

Well yea, finding the initial bug, but finding the reason for the change is reasonably doable I think