Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(server_openvr, linux): Fix intel graphics failing to run ALVR #2664

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

Meister1593
Copy link
Collaborator

@Meister1593 Meister1593 commented Jan 25, 2025

Fixes #2014

Known issues around intel graphics in alvr:

  • Software encoding doesn't work (crashes steamvr)
  • Quality looks different compared to vaapi on amd, might be issues with parameters passed to ffmpeg (compression doesn't seem to affect it much)
  • Games still don't work (they appear to have tracking, but not showing up inside steamvr), but it might be unrelated issue

Tested on Intel Arc laptop graphics (intel ultra 9)

@Meister1593
Copy link
Collaborator Author

huh
clang-format check failed for /home/runner/work/ALVR/ALVR/alvr/server_openvr/cpp/alvr_server/Controller.h
i think theres some problems with check format and format in xtasks, since i used it to format

@The-personified-devil
Copy link
Collaborator

clang-format sometimes behaves slightly different in specific instances between versions and in that case you probably have a different version than actions has. (Tho an actual diff and not just a failure message might be slightly nicer.) Just remove the changes from that file and that should go away.

@The-personified-devil
Copy link
Collaborator

Sorry that this is such a drag, I should've just done it myself in 5 minutes when I originally commented on that issue, I was just too lazy (nvm that it's just plain annoying as you can see). But it's complex to get this right in C++, so see this as a learning opportunity I guess.

@Meister1593
Copy link
Collaborator Author

Sorry that this is such a drag, I should've just done it myself in 5 minutes when I originally commented on that issue, I was just too lazy (nvm that it's just plain annoying as you can see). But it's complex to get this right in C++, so see this as a learning opportunity I guess.

Yeah i mostly wanted to make sure it at least works on intel and see if i can do something in this part of codebase, even though with help. Don't worry about the drag

@Meister1593
Copy link
Collaborator Author

One more note: while it seems like alvr and steamvr works, some (maybe all?) vr games seem to not display inside vr.
Might be separate bug, but probably needs investigating to make it fully playable

@Meister1593
Copy link
Collaborator Author

In either case, i think alvr at least started to work with steamvr, i think it can be merged as at least partial support
I might test with older vulkan driver for intel too, just to make sure if it will work

Copy link
Collaborator

@The-personified-devil The-personified-devil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I'm kinda reviewing my own code, but LGTM. I think the most value would actually be testing by nvidia users, but fwiw we can just do that via nightlies.

Copy link
Member

@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say anything about the content of the PR, but no problems about style

@The-personified-devil The-personified-devil merged commit ae76f9b into master Jan 30, 2025
8 checks passed
@The-personified-devil The-personified-devil deleted the fix_intel branch January 30, 2025 17:16
zmerp pushed a commit that referenced this pull request Mar 9, 2025
)

* Fix intel failing with vulkan error

* Clang format

* Move vk frame ctx to nvenc

* Remove unnecessary std::optional

* Fix format, add vk_frame_ctx as internal member of nvenc pipeline

* Fix destruction order for vk_frame_ctx and pass create struct as reference
@zmerp zmerp mentioned this pull request Mar 9, 2025
zmerp pushed a commit that referenced this pull request Mar 11, 2025
)

* Fix intel failing with vulkan error

* Clang format

* Move vk frame ctx to nvenc

* Remove unnecessary std::optional

* Fix format, add vk_frame_ctx as internal member of nvenc pipeline

* Fix destruction order for vk_frame_ctx and pass create struct as reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Encoder: Image creation failure: Unknown error" after update to Mesa 23.3.6
3 participants