-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix(server_openvr, linux): Fix intel graphics failing to run ALVR #2664
Conversation
huh |
|
Sorry that this is such a drag, I should've just done it myself in 5 minutes when I originally commented on that issue, I was just too lazy (nvm that it's just plain annoying as you can see). But it's complex to get this right in C++, so see this as a learning opportunity I guess. |
Yeah i mostly wanted to make sure it at least works on intel and see if i can do something in this part of codebase, even though with help. Don't worry about the drag |
One more note: while it seems like alvr and steamvr works, some (maybe all?) vr games seem to not display inside vr. |
In either case, i think alvr at least started to work with steamvr, i think it can be merged as at least partial support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know I'm kinda reviewing my own code, but LGTM. I think the most value would actually be testing by nvidia users, but fwiw we can just do that via nightlies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say anything about the content of the PR, but no problems about style
Fixes #2014
Known issues around intel graphics in alvr:
Tested on Intel Arc laptop graphics (intel ultra 9)