-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(dashboard): dashboard improvements, codec & foveation presets #2704
Conversation
Meister1593
commented
Feb 15, 2025
•
edited
Loading
edited
- Improvements to sign about not running steamvr (easier to understand)
- Added more notes to various places in dashboard and changed strings (statistics without connected client, debug tab for recording buttons, changed few notifications and added one more)
- Added presets for foveation and codec
- Adjusted all presets to go from low-to-high (or first disabled, then others)
- Added a note to foveated encoding (to prevent users from disabling them without knowing the risks)
- (internal) Higher order choice now uses display name for default value instead of indexes
- Nvidia icd vulkan paths are now checked and chosen from two available ones and fallback to env param (i thought about finding first available, but using 32 bit vulkan icd most likely will break steamvr, playing it safe here)
- Microphone on windows now disabled by default
Closes #2189 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beside the comments below, you have clippy and format to fix
alvr/dashboard/src/dashboard/components/settings_controls/presets/builtin_schema.rs
Show resolved
Hide resolved
alvr/dashboard/src/dashboard/components/settings_controls/presets/higher_order_choice.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm aware english is far from your first language, but running updated help strings through a grammar checker might be worthwhile as badly worded ones can make it even harder to understand what to do, especially if a user also isn't that good at english.
alvr/dashboard/src/dashboard/components/settings_controls/presets/builtin_schema.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR still needs fixing some lints, and replacing the critical tooltip with notice. I can work on notice first in another PR then you can rebase
I was meaning to do a PR but I pushed to master by mistake... in any case this PR can be rebased, and use the new notice field string in place of the critical tooltip |
I haven't noticed any issues with rounding that is caused by this PR, and actually for ex. latency overstep modifier being set to |
@zmerp You're right actually, however there's a simple workaround where it'll actually round to the number of valid places, not decimals (I got confused prior by assuming we were using this mode actually). See this example. This however does break larger integers at a certain point, so as I already mentioned we need to treat those separately. For floats however this should be perfect. However this should only be used in the comparison, not in the rounding when storing (which is kinda useless in the first place, but shouldn't really matter all things considered). |
Good call, we should use the .Xe notation then, and exclude integers |
39fee93
to
a5f6b3d
Compare
a5f6b3d
to
bb65c25
Compare
62fc5f3
to
d65f13b
Compare
d65f13b
to
85b6031
Compare
@The-personified-devil @Meister1593 Let me know if this is mergeable. I am aware of the disagreement on how to handle float comparison. The current method is affected by these issues: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=5657af39041c776b9957976adaa93a53 |
alvr/dashboard/src/dashboard/components/settings_controls/mod.rs
Outdated
Show resolved
Hide resolved
alvr/dashboard/src/dashboard/components/settings_controls/number.rs
Outdated
Show resolved
Hide resolved
I'm okay with any solution that works with that really, comment should suffice for the time being |
Only that one thing btw, after that the pr is fully done and ready to merge. |
The value equality check should be fixed for real now |
alvr/dashboard/src/dashboard/components/settings_controls/mod.rs
Outdated
Show resolved
Hide resolved
ca88d40
to
b85e8b7
Compare