-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(steamvr): auto-unblock ALVR driver on startup #2708
feat(steamvr): auto-unblock ALVR driver on startup #2708
Conversation
d6827e3
to
9c7f08b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid crashes, all unwrap()
s should be removed and replaced with proper error handling
9c7f08b
to
3f8bfaf
Compare
Fixed. Feel free to point me to any other samples or let me know of any nits -- I'm relatively new to Rust in such a code-base. |
3f8bfaf
to
b90bb09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me. Someone else on linux like @Meister1593 should also review and test this PR before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simulated scenario (put crash state into same file), works fine, though i rarely get any real crash events nowadays.
Only small changes needed, otherwise looks good
64661e7
to
2dd763b
Compare
Goes into `steamvr.vrsettings` and unblocks ALVR if it is blocked.
2dd763b
to
20a9955
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it (and I honestly can't be bothered to force steamvr to crash), but lgtm (tho quite verbose, which might honestly be good considering this is messing with steamvr's rather fragile internals).
Rarely? |
Goes into `steamvr.vrsettings` and unblocks ALVR if it is blocked.
Goes into `steamvr.vrsettings` and unblocks ALVR if it is blocked.
I'm really not sure what the path is on Windows. I found some references but not a full path, and especially it varies.
This will go into
steamvr.vrsettings
and toggleblocked_by_safe_mode
if needed for the ALVR driver. Should fail gracefully as long as the file exists.Windows is not implemented because: