feat(client_openxr): Add support for Play for Dream MR + misc fixes for it #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shinyquagsire23
commented
Feb 19, 2025
•
shinyquagsire23
commented
- Add PFD MR to platform matcher as a YVR headset
- YVR runtime complains about the passthrough flags needing to be non-zero, and they're right
- Fix the color space to be Rec.709, technically it should be Display P3 (P3 with an sRGB white point) or sRGB, but those aren't options and Rec.709 is easy to work with for H26x anyway.
shinyquagsire23
changed the title
zmerp
requested changes
Feb 19, 2025
zmerp
requested changes
Feb 19, 2025
|
Arguably, it would actually be better if we removed YVR support, it seems that it's actually broken (black screen) and we don't have means of testing. |
|
Regarding #2696: probably it should be fixed by |
|
Yeah the passthrough flags thing prevented the app from showing any frames at all, that would be my best guess for that issue. |
zmerp
requested changes
Feb 20, 2025
zmerp
requested changes
Feb 21, 2025
|
FFMPEG zip file link |
|
The PR can be rebased |
This reverts commit 107de43.
shinyquagsire23
force-pushed
the
fix-pfd-mr
branch
from
5389db2 to
a95eb2c
Compare
|
rebase'd |
zmerp
approved these changes
Feb 23, 2025
zmerp
pushed a commit
that referenced
this pull request
Mar 9, 2025
…or it (#2713) * Fix PFD MR OpenXR loader -> YVR * OpenXR spec says flags must be non-zero and YVR correctly calls us out on it * Use Rec.709 color space * format my behated * Fix passthrough for real * README * Note down the YVR hack * Tweak the YVR hack * Revert "Tweak the YVR hack" This reverts commit 107de43. * YVR conditional hack * nits * nits 2
Merged
zmerp
pushed a commit
that referenced
this pull request
Mar 11, 2025
…or it (#2713) * Fix PFD MR OpenXR loader -> YVR * OpenXR spec says flags must be non-zero and YVR correctly calls us out on it * Use Rec.709 color space * format my behated * Fix passthrough for real * README * Note down the YVR hack * Tweak the YVR hack * Revert "Tweak the YVR hack" This reverts commit 107de43. * YVR conditional hack * nits * nits 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.