fix(client_openxr): 🐛 Fix controllers pose for each headset #2751
+66
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a soft breaking change fixing controller pose per-platform and changing defaults on the server side. This is a soft breaking change because users usually start with a new session file when updating the ALVR server. Changing defaults would become a hard breaking change once we have a Steam release or any other mechanism to automatically transfer the session to new ALVR versions.
Tested on Quest 1, Quest 3, Pico Neo 3, Pico 4 Ultra, Vive Focus Vision. Notably missing: Quest 2, Pico 4 (base). I will make a separate PR next month when I will have access to these 2 headsets.
It seems that the controller pose displayed by SteamVR has some weird offset dependent on the orientation of the controller. This is a bug that existed before this PR. It could be fixed in the future, in any case the offset is minor (max 1.5cm per axis).