feat(server_openvr): ✨ Defer TrackedDevices initialization #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmerp
force-pushed
the
deferred-steamvr-init
branch
from
c581a03 to
45477fb
Compare
zmerp
force-pushed
the
deferred-steamvr-init
branch
from
45477fb to
e06ab43
Compare
zmerp
force-pushed
the
deferred-steamvr-init
branch
from
bd3855a to
511a005
Compare
| this->device_class, | ||
| (vr::ITrackedDeviceServerDriver*)this | ||
| )) { | ||
| Error("Failed to register device"); |
There was a problem hiding this comment.
This could maybe use some additional information like the serial number, to aid in debugging
| ptr, | ||
| }; | ||
|
|
||
| pub fn set_openvr_prop(device_id: u64, prop: OpenvrProperty) { | ||
| pub fn set_openvr_prop(instance_ptr: Option<*mut c_void>, device_id: u64, prop: OpenvrProperty) { |
There was a problem hiding this comment.
not the biggest fan of this api, since it behaves like an enum but isn't one, but it's fine if need be
There was a problem hiding this comment.
What do you mean enum? Do you think we should just check for null pointer? (maybe we should)
There was a problem hiding this comment.
You use either a device id or a instance ptr, so an enum DeviceHandle { DeviceId, Pts }
There was a problem hiding this comment.
that won't work because I use the device_id always, and only optionally instance_ptr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I make the following changes:
DriverProvider::Init()toInitializeStreaming()TrackedDevice::registrer_device()now waits for theITrackedDeviceServerDriver::Activate()call.g_driver_provideruntil they are successfully activated. This requires changing the signature ofSetOpenvrProps()andRegisterButtons()to reference the devices by pointer instead of ID. Allow controllers and trackers to fail registration (we are already handling the absence of any of these devices)Notably, In this PR i'm not implementing the skip of the first SteamVR restart when the client first connects, this will be done in the next PRs.