vendor._gowin: fix comment syntax for add_preferences #1563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amaranth version
0.6.0.dev76
minimal program that demonstrates
run
TangNano9kPlatform().build(AnyElaboratableClass(), do_program=True)
Warning: Invalid constraint: # (add_preferences placeholder) 1 warning, 0 errors
What you expected to happen, and what actually happened
Tracing the cause from the error logs, the problem is probably in the commented out text appended by default in
add_preferences
.The IO constraints file (.cst) in the gowin platform handles commentouts with
//
, butadd_preferences
handles them with#
.I assume that it is probably mistaken for commentout in .ys.