-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d2 has no shorthand flag 'o'. Update to support org-src. #34
Conversation
Signed-off-by: Randolph HUANG <[email protected]>
@wowhxj Thank you for the PR! LGTM. Will run the check and then merge. |
@wowhxj looks like a whitespace is at the end, failing elisp check. Can you fix the formatting? The content looks good though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: suggestion to remove whitespace. Thank you for the PR!
d2-mode.el
Outdated
@@ -114,8 +114,8 @@ | |||
(error "D2 requires a \":file\" header argument"))) | |||
(temp-file (org-babel-temp-file "d2-")) | |||
(cmd (concat (shell-quote-argument d2-location) | |||
" -o " (org-babel-process-file-name out-file) | |||
" -i " temp-file | |||
" " temp-file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
" " temp-file | |
" " temp-file |
Signed-off-by: Randolph HUANG <[email protected]>
merged! Thanks @wowhxj |
Sorry for the late response. Thanks for your quick action. :-) |
Based on d2 help doc, d2 doesn't have shorthand flag 'o'. Change
org-babel-default-header-args:d2
function to make org-src block work.