Added all the Proxima Nova font files and enabled them in the CSS #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreareginato
added a commit
that referenced
this pull request
Jan 25, 2012
Added all the Proxima Nova font files and enabled them in the CSS
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added all the Proxima Nova font files found into http://foundation.zurb.com/fonts/ to "assets/fonts" and I have re-enabled the @font-face section into the CSS.
I have added all the fonts I have found in the Foundation's website but there are two groups of fonts which are not referenced into the CSS: "black" and "regularitalic". The first is bolder then the "bold" font, the second is the same of "regitalic"; both are not present in the CSS so I think they will not be loaded by the browser. I was in doubt if remove them or not and, at the end, I leave them. If you think are needless, fell free to delete them. The files are:
I tried to load the page into Firefox, Chrome and Safari on my Mac and the font seems to be loaded correctly. I also tried the website under IE8 but I didn't see changes, so I tried to understand why but I didn't found a reason. I've noticed that if I change the "browser mode" from IE8 to IE7 then the font seems to be loaded.... bah!
Andrea