Support for webpack 4 #261

dmitmel · 2018-03-25T16:21:27Z

Related to #255

vlad-zhukov · 2018-03-26T13:54:38Z

packages/dev-server/CHANGELOG.md

@@ -1,5 +1,9 @@
 # @webpack-blocks/dev-server - Changelog

+## Next Release
+
+- Removed `NamedModulesPlugin` because webpack 4 automatically adds it in the `development` mode ([#255](https://github.com/andywer/webpack-blocks/issues/255))


vlad-zhukov · 2018-03-26T13:55:45Z

packages/dev-server/package.json

@@ -19,7 +19,7 @@
  "repository": "andywer/webpack-blocks",
  "bugs": "https://github.com/andywer/webpack-blocks/issues",
  "dependencies": {
-    "webpack-dev-server": "^2.9.1"
+    "webpack-dev-server": "^2.11.2"


webpack-dev-server 3+?

vlad-zhukov · 2018-03-26T13:56:31Z

packages/dev-server/package.json

@@ -19,7 +19,7 @@
  "repository": "andywer/webpack-blocks",
  "bugs": "https://github.com/andywer/webpack-blocks/issues",
  "dependencies": {
-    "webpack-dev-server": "^2.9.1"
+    "webpack-dev-server": "^2.11.2"
  },
  "peerDependencies": {
    "webpack": "2.x || 3.x"


It's going to be v4 only.

Here and in other places

jeremy-clearlabs · 2018-04-20T20:39:24Z

@dmitmel Sent you a PR on your fork for updating your pull request that resolves the conflicts.

vlad-zhukov · 2018-04-21T15:01:55Z

There are too many changes for a single PR. It's very difficult to review it and I don't want to miss something important out. I would like to migrate to yarn first, then it will be much easier to work on this PR as well as others.

vlad-zhukov · 2018-04-24T16:55:47Z

I had to rewrite the commit history because this branch had like 20 commits and merges, originally targeted master and was eventually bricked.

I feel like we have to split this PR into 2: one that upgrades dependencies and makes everything work with webpack 4, and one with the new blocks and reworked tests. While the 1st part can be safely merged (if tests pass), the 2nd part is still under consideration and API was not really discussed.

vlad-zhukov · 2018-04-24T20:07:33Z

@dmitmel You've reverted the branch history but the branch is inconsistent with the v2. Git (and GitHub) doesn't display the correct difference in this case (it's very unintuitive but that's how git works) unless you try to merge it into v2. If you try weird changes happen, for example packages/eslint/package-lock.json was added (!?).

I wanted to prevent this, that's why I squashed all commits into one.

dmitmel · 2018-04-25T04:45:05Z

@vlad-zhukov Can this PR be merged now?

zcei · 2018-04-25T05:37:24Z

@dmitmel no, I think you've reintroduced the inconsistencies again? Also we just merged the changes for moving Elm out, which conflicts with a few of your changes. Those need to be resolved first.

dmitmel · 2018-04-25T05:55:28Z

I think you've reintroduced the inconsistencies again

What do you mean by "inconsistencies"?

Also we just merged the changes for moving Elm out

I'll try to merge those later today.

zcei · 2018-04-25T08:34:05Z

What do you mean by "inconsistencies"?

What Vlad described here #261 (comment), no?

vlad-zhukov · 2018-04-29T21:04:42Z

packages/webpack/__tests__/end-to-end.test.js

@@ -28,7 +28,7 @@ test('building the babel/postcss/extract-text project works', async (t) => {

  // Check if bundle contains injected process.env.TEST
  const bundleContents = await fs.readFile(path.join(buildPath, 'bundle.js'), { encoding: 'utf8' })
-  t.true(bundleContents.indexOf('module.exports = "This is the injected process.env.TEST!"') > -1)
+  t.true(bundleContents.indexOf('.exports="This is the injected process.env.TEST!"') > -1)


This is because the code is minified by default. Changed it back in #274.

vlad-zhukov · 2018-04-29T21:06:16Z

I've split new blocks into #274. Also upgraded almost all dependencies to latest.

This is ready for a final review! @andywer @zcei @jvanbruegge

andywer

Looks good 👍
Not sure about the state of the inconsistencies discussion. Waiting for an update on this before approving.

andywer · 2018-04-30T05:34:25Z

packages/uglify/README.md

@@ -8,16 +8,15 @@ This block provides UglifyJS webpack plugin configuration for [webpack-blocks](h

 Based on [uglifyjs-webpack-plugin](https://github.com/webpack-contrib/uglifyjs-webpack-plugin) (not `webpack.optimize.UglifyJsPlugin`) which uses UglifyJS v3 (uglify-es) that supports ECMAScript 2015.

+**This block will only work in the `production` mode.**


Idea: Let’s turn mode into a link to the setMode docs.

In the other PR.

vlad-zhukov · 2018-05-01T10:46:42Z

Updated changelogs of all blocks.

@andywer It's all fine, I've squashed and rebased all commits to fix this problem.

vlad-zhukov · 2018-05-01T18:40:19Z

Rebased. Due to dependency changes this PR blocks lots of new ones (2 have been already opened and at least 2 more are also ready). 😅

andywer · 2018-05-02T06:25:16Z

Looks fine, no one's complaining. Let's merge it 😉

dmitmel · 2018-05-02T06:32:03Z

@andywer Let's publish a pre-relase version with webpack 4 support

dmitmel force-pushed the feature/webpack-4 branch from 3401a8f to dbc16e9 Compare March 25, 2018 19:42

vlad-zhukov reviewed Mar 26, 2018

View reviewed changes

jeremy-clearlabs mentioned this pull request Apr 20, 2018

Updates to Webpack 4 dmitmel/webpack-blocks#1

Merged

vlad-zhukov added this to the 2.0.0 milestone Apr 21, 2018

vlad-zhukov changed the base branch from master to release-2.0 April 24, 2018 05:50

vlad-zhukov force-pushed the feature/webpack-4 branch 2 times, most recently from 8a78a64 to fc926be Compare April 24, 2018 12:58

vlad-zhukov force-pushed the feature/webpack-4 branch 3 times, most recently from 1fcab0d to 57ab05c Compare April 25, 2018 07:20

vlad-zhukov mentioned this pull request Apr 29, 2018

Add new webpack 4 blocks #274

Merged

vlad-zhukov reviewed Apr 29, 2018

View reviewed changes

andywer reviewed Apr 30, 2018

View reviewed changes

Vlad Zhukov added 5 commits May 1, 2018 20:20

Squashed and rebased

379f6c1

Revert adding new blocks

b88c07c

Upgrade deps

4b06d9b

Upgrade deps

5e4e128

Update changelogs

e013e6c

vlad-zhukov force-pushed the feature/webpack-4 branch from 2177ad8 to e013e6c Compare May 1, 2018 17:20

andywer approved these changes May 2, 2018

View reviewed changes

andywer merged commit 3ec6370 into andywer:release-2.0 May 2, 2018

dmitmel deleted the feature/webpack-4 branch May 2, 2018 06:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for webpack 4 #261

Support for webpack 4 #261

dmitmel commented Mar 25, 2018

vlad-zhukov Mar 26, 2018

dmitmel Mar 26, 2018

vlad-zhukov Mar 26, 2018

dmitmel Mar 26, 2018

vlad-zhukov Mar 26, 2018

vlad-zhukov Mar 26, 2018

dmitmel Mar 26, 2018

jeremy-clearlabs commented Apr 20, 2018

vlad-zhukov commented Apr 21, 2018

vlad-zhukov commented Apr 24, 2018

vlad-zhukov commented Apr 24, 2018

dmitmel commented Apr 25, 2018

zcei commented Apr 25, 2018

dmitmel commented Apr 25, 2018

zcei commented Apr 25, 2018

vlad-zhukov Apr 29, 2018

vlad-zhukov commented Apr 29, 2018 •

edited

Loading

andywer left a comment

andywer Apr 30, 2018

vlad-zhukov May 1, 2018

vlad-zhukov commented May 1, 2018

vlad-zhukov commented May 1, 2018

andywer commented May 2, 2018

dmitmel commented May 2, 2018

		@@ -8,16 +8,15 @@ This block provides UglifyJS webpack plugin configuration for [webpack-blocks](h

		Based on [uglifyjs-webpack-plugin](https://github.com/webpack-contrib/uglifyjs-webpack-plugin) (not `webpack.optimize.UglifyJsPlugin`) which uses UglifyJS v3 (uglify-es) that supports ECMAScript 2015.

		This block will only work in the `production` mode.

Support for webpack 4 #261

Support for webpack 4 #261

Conversation

dmitmel commented Mar 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeremy-clearlabs commented Apr 20, 2018

vlad-zhukov commented Apr 21, 2018

vlad-zhukov commented Apr 24, 2018

vlad-zhukov commented Apr 24, 2018

dmitmel commented Apr 25, 2018

zcei commented Apr 25, 2018

dmitmel commented Apr 25, 2018

zcei commented Apr 25, 2018

Choose a reason for hiding this comment

vlad-zhukov commented Apr 29, 2018 • edited Loading

andywer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vlad-zhukov commented May 1, 2018

vlad-zhukov commented May 1, 2018

andywer commented May 2, 2018

dmitmel commented May 2, 2018

vlad-zhukov commented Apr 29, 2018 •

edited

Loading